search

SauceCat / PDPbox

python partial dependence plot toolbox
http://pdpbox.readthedocs.io/en/latest/
MIT License
840 stars 129 forks source link

The contour_label_fontsize parameter in _pdp_contour_plot() causes TypeError #40

Closed angertdevsingh closed 3 years ago

angertdevsingh commented 5 years ago

On line 251 in pdp_plot_utils.py, one of the parameters for _pdp_contour_plot() is contour_label_fontsize and this causes the following error:

TypeError: clabel() got an unexpected keyword argument 'contour_label_fontsize'

According to the documentation for matplotlib.pyplot.clabel(), the parameter should be called fontsize.

Source: clabel() documentation

jcusick13 commented 5 years ago

Hi @SauceCat, I was wondering if there were plans coming up to push a new release version out to PyPI that included this fix. Thanks!

Wolemercy commented 4 years ago

This worked. Merci!

Photonsinnovate commented 4 years ago

This worked. Merci!

Hi Wolemercy, Could you please explain exactly how you made it work?

Photonsinnovate commented 4 years ago

This worked. Merci!

Hi Wolemercy, Could you please explain exactly how you made it work?

Hi Wole, I have resolved this. Thank you

Wolemercy commented 4 years ago

Cheers mate

johann-DP commented 4 years ago

Hi, Sorry Wolemercy but I don't… Could you explain ti me, please ?

Wolemercy commented 4 years ago

Aye aye You need to locate this python file "pdp_plot_utils.py" on your PC. It's part of the PDPBox package you installed. Open the file and replace the code in line 251 with this:

inter_ax.clabel(c2, fontsize=fontsize, inline=1)

Save and close the file. You should be good to go.

johann-DP commented 4 years ago

Hi, merci pour le retour mais ça marche pô : toujours le même pb… Je pense qu'il faut downgrader un package mais je ne vois pas lequel.

johann-DP commented 4 years ago

Oups, it works! (I forgoted to restart… once again). Thanks a lot!

JRBOH commented 3 years ago

This helped me, especially @Wolemercy's comment! Thanks, guys.

Wolemercy commented 3 years ago

You're welcome!

On Mon, 8 Jun 2020 at 10:48, johann notifications@github.com wrote:

Oups, it works! (I forgoted to restart… once again). Thanks a lot!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SauceCat/PDPbox/issues/40#issuecomment-640497273, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMQ4273NH6TQCIBTZ4PR3K3RVSXXBANCNFSM4F6PRFLA .

-- Best Regards, 'Wole Ajewole.

"We are what we repeatedly do. Excellence, then, is not an act but a habit"'

Wolemercy commented 3 years ago

Cheers mate!

On Fri, 13 Nov 2020 at 07:46, JRBOH notifications@github.com wrote:

This helped me, especially @Wolemercy https://github.com/Wolemercy's comment! Thanks, guys.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SauceCat/PDPbox/issues/40#issuecomment-726557670, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMQ4273XBMQUFOFDMZCAMIDSPTI4HANCNFSM4F6PRFLA .

-- Best Regards, 'Wole Ajewole.

"We are what we repeatedly do. Excellence, then, is not an act but a habit"'

Batev commented 3 years ago

Hi @SauceCat, I was wondering if there were plans coming up to push a new release version out to PyPI that included this fix. Thanks!

Still waiting for the PyPI update ...

veeralakrishna commented 3 years ago

Why it's not updated in the PyPI yet??

SauceCat commented 3 years ago

Hi, can you try installing from GitHub repo instead? Because this repo is not actively maintaining currently.

On Tue, 9 Mar 2021 at 4:17 PM, Veerala Hari Krishna < notifications@github.com> wrote:

Why it's not updated in the PyPI yet??

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SauceCat/PDPbox/issues/40#issuecomment-793529228, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXNPFGI7MWB7H62GZ7JKRDTCXKTBANCNFSM4F6PRFLA .

Batev commented 3 years ago

Both installing from the repo and editing the file as @Wolemercy suggested work fine. However, it is really inconvenient to have to manually install PDPBox because of this bug instead of using pip and a requirements file. Since the repo is no longer supported I/we would be happy to at least have the latest version in PyPI.

SauceCat commented 3 years ago

Understand, let me try to figure it out these days.

On Tue, 9 Mar 2021 at 6:56 PM, Evgeni notifications@github.com wrote:

Both installing from the repo and editing the file as @Wolemercy https://github.com/Wolemercy suggested work fine. However, it is really inconvenient to have to manually install PDPBox because of this bug instead of using pip and a requirements file. Since the repo is no longer supported I/we would be happy to at least have the latest version in PyPI.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SauceCat/PDPbox/issues/40#issuecomment-793713008, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXNPFG6ACEJPYZQWY3BMW3TCX5FLANCNFSM4F6PRFLA .

SauceCat commented 3 years ago

@Batev @veeralakrishna Please check the new release.

veeralakrishna commented 3 years ago

Thank you for the New Release @SauceCat