Replace the value grid calculation by removing nans

SauceCat / PDPbox

python partial dependence plot toolbox

http://pdpbox.readthedocs.io/en/latest/

MIT License

840 stars 129 forks source link

Replace the value grid calculation by removing nans #79

Open ciornav opened 2 years ago

ciornav commented 2 years ago

Hello,

would be good to replace the grid value calculation in pdp_calc_utils.py line 237: value_grids = np.percentile(feature_values, percentile_grids) with value_grids = np.nanpercentile(feature_values, percentile_grids) This will avoid returning an array with nans only if the amount of nans is high in the dataset.

SauceCat commented 1 year ago

The latest version, v0.3.0, has been released. We recommend updating to this version and checking if it resolves the issue you're facing. Your feedback is appreciated. Thank you for your patience and support.