SauceCat / PDPbox

python partial dependence plot toolbox
http://pdpbox.readthedocs.io/en/latest/
MIT License
840 stars 129 forks source link

Use scikit-learn instead of sklearn #84

Open Philmod opened 1 year ago

Philmod commented 1 year ago

Otherwise it fails to install:

#36 272.1   × python setup.py egg_info did not run successfully.
#36 272.1   │ exit code: 1
#36 272.1   ╰─> [18 lines of output]
#36 272.1       The 'sklearn' PyPI package is deprecated, use 'scikit-learn'
#36 272.1       rather than 'sklearn' for pip commands.
#36 272.1       
#36 272.1       Here is how to fix this error in the main use cases:
#36 272.1       - use 'pip install scikit-learn' rather than 'pip install sklearn'
#36 272.1       - replace 'sklearn' by 'scikit-learn' in your pip requirements files
#36 272.1         (requirements.txt, setup.py, setup.cfg, Pipfile, etc ...)
#36 272.1       - if the 'sklearn' package is used by one of your dependencies,
#36 272.1         it would be great if you take some time to track which package uses
#36 272.1         'sklearn' instead of 'scikit-learn' and report it to their issue tracker
#36 272.1       - as a last resort, set the environment variable
#36 272.1         SKLEARN_ALLOW_DEPRECATED_SKLEARN_PACKAGE_INSTALL=True to avoid this error
#36 272.1       
#36 272.1       More information is available at
#36 272.1       https://github.com/scikit-learn/sklearn-pypi-package
jamesmyatt commented 1 year ago

See https://github.com/SauceCat/PDPbox/pull/77

jamesmyatt commented 1 year ago

It's probably worth updating the exact pin on matplotlib ==3.1.1 too

Philmod commented 1 year ago

See #77

The PR you link was closed. Any reason not to move to scikit-learn?

SauceCat commented 1 year ago

The latest version, v0.3.0, has been released. We recommend updating to this version and checking if it resolves the issue you're facing. Your feedback is appreciated. Thank you for your patience and support.

jamesmyatt commented 1 year ago

https://github.com/SauceCat/PDPbox/blob/7fae76b895f705124b137dfacb55bce22a828bd6/requirements.txt#LL9C1-L9C13

Should be scikit-learn not scikit_learn. See https://pypi.org/project/scikit-learn/. This is also a security issue.