SauceLLC / sauce4strava

Sauce for Strava™
MIT License
202 stars 23 forks source link

Kudo All doesn't work in Firefox 99.0.1 (64-bit) #113

Closed v1sionmaster closed 2 years ago

v1sionmaster commented 2 years ago

Kudos All works perfectly in MS Edge, but fails in Firefox 99.0.1 (64-bit). The button animates but no action is carried out. Sauce V 8.0.8 (a67c1b8a23) I see there was a related report recently that has now been closed, but there was no detailed info from the OP to be able to tell if this is related to the specific browser. Thanks for all of your wonderful work!!!

mayfield commented 2 years ago

Hi @v1sionmaster. This is probably minor discrepancy between your sauce versions and what dashboard site Strava is sending you as of right now. They have been very slowly rolling out a new dashboard to everyone since last week. I'm not sure how they do it exactly, but it seems to be based on region or account. I had users reporting bugs to me about the new site almost a week before I was able to make a patch because I was still getting the old site.

Re: sauce versions, can you double check that you're on v8.0.8 for Firefox and for Edge? The git commit you listed a67c1b8 is not from 8.0.8 is why I ask. I'm guessing one of your browsers is actually an older release and depending on which dashboard Strava is sending you, one of the browsers will work and the other won't because they are on different Sauce versions.

In either case I believe once all your browsers update to v8.0.8 and Strava has finished their slow rollout you should be working properly. To find out if you're getting the old Strava dashboard feed you can open devtools on the dashboard page run this in the console tab:

document.querySelectorAll('.react-feed-component[data-react-props]')

If you get nothing back or an empty list then you're still on the old Strava dashboard and will probably get updated within a few days.

Let me know what you figure out and we can work from there.

mayfield commented 2 years ago

Gonna close this one out, please reopen if you're still having issues with all the latest versions.

v1sionmaster commented 2 years ago

Thanks Justin! J

From: Justin Mayfield @.*** Sent: 29 April 2022 20:18 To: SauceLLC/sauce4strava Cc: Tim; Mention Subject: Re: [SauceLLC/sauce4strava] Kudo All doesn't work in Firefox 99.0.1 (64-bit) (Issue #113)

Gonna close this one out, please reopen if you're still having issues with all the latest versions.

— Reply to this email directly, view it on GitHub https://github.com/SauceLLC/sauce4strava/issues/113#issuecomment-1113644424 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJI5T5QEEN2KADD5EJXH3GDVHQYWVANCNFSM5ULCQFWA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AJI5T5VSWGAQVZV3CZCCZ2DVHQYWVA5CNFSM5ULCQFWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIJQN3CA.gif Message ID: @.***>

v1sionmaster commented 2 years ago

Hi Justin!

THANKS for the quick reply!

Yes it appears that Firefox has v7.35 from November 2021

Edge shows 8.0.8

I get this back from the Web Developer Tools NodeList [ div.content.react-feed-component ] which I assume is the same as ‘nothing back’ and = the old Strava dashboard..

None of this is a big concern for me, I just wanted to alert you to it in case others report the same issue J.

Best wishes and thanks for the best tasting sauce I know ;-)

Tim

From: Justin Mayfield @.*** Sent: 26 April 2022 10:03 To: SauceLLC/sauce4strava Cc: Tim; Mention Subject: Re: [SauceLLC/sauce4strava] Kudo All doesn't work in Firefox 99.0.1 (64-bit) (Issue #113)

Hi @v1sionmaster https://github.com/v1sionmaster . This is probably minor discrepancy between your sauce versions and what dashboard site Strava is sending you as of right now. They have been very slowly rolling out a new dashboard to everyone since last week. I'm not sure how they do it exactly, but it seems to be based on region or account. I had users reporting bugs to me about the new site almost a week before I was able to make a patch because I was still getting the old site.

Re: sauce versions, can you double check that you're on v8.0.8 for Firefox and for Edge? The git commit you listed https://github.com/SauceLLC/sauce4strava/commit/a67c1b8a236f4382c6b5aa54f3f5f9b72298be52 a67c1b8 is not from 8.0.8 is why I ask. I'm guessing one of your browsers is actually an older release and depending on which dashboard Strava is sending you, one of the browsers will work and the other won't because they are on different Sauce versions.

In either case I believe once all your browsers update to v8.0.8 and Strava has finished their slow rollout you should be working properly. To find out if you're getting the old Strava dashboard feed you can open devtools on the dashboard page run this in the console tab:

document.querySelectorAll('.react-feed-component[data-react-props]')

If you get nothing back or an empty list then you're still on the old Strava dashboard and will probably get updated within a few days.

Let me know what you figure out and we can work from there.

— Reply to this email directly, view it on GitHub https://github.com/SauceLLC/sauce4strava/issues/113#issuecomment-1109540432 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AJI5T5UT7EVNOP2I6MZ2OJTVG6WNBANCNFSM5ULCQFWA . You are receiving this because you were mentioned. https://github.com/notifications/beacon/AJI5T5UC7QXP3KLIPIQOSK3VG6WNBA5CNFSM5ULCQFWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIIRD4UA.gif Message ID: @.***>