search

Saul-Mirone / prosemirror-adapter

Universal adapter to create prosemirror nodeview from modern UI frameworks.
MIT License
97 stars 7 forks source link

Svelte 4 support? #39

Closed rchrdnsh closed 1 year ago

rchrdnsh commented 1 year ago 
npm install @prosemirror-adapter/svelte
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: lstv@0.0.1
npm ERR! Found: svelte@4.0.5
npm ERR! node_modules/svelte
npm ERR!   dev svelte@"^4.0.5" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer svelte@"^3.57.0" from @prosemirror-adapter/svelte@0.2.5
npm ERR! node_modules/@prosemirror-adapter/svelte
npm ERR!   @prosemirror-adapter/svelte@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/rchrdnsh/.npm/_logs/2023-07-15T23_53_13_299Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/rchrdnsh/.npm/_logs/2023-07-15T23_53_13_299Z-debug-0.log

when installing...

rchrdnsh commented 1 year ago

stringe, as your peer dep is indeed svelte 4:

  "peerDependencies": {
    "svelte": "^4.0.0"
  },

...???

Saul-Mirone commented 1 year ago

Can you please provide a reproduction or your package.json?

rchrdnsh commented 1 year ago

sure, here you go:

{
    "name": "lstv",
    "version": "0.0.1",
    "private": true,
    "scripts": {
        "dev": "vite dev",
        "build": "vite build",
        "preview": "vite preview",
        "check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json",
        "check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch"
    },
    "devDependencies": {
        "@sveltejs/adapter-auto": "^2.1.0",
        "@sveltejs/kit": "^1.22.3",
        "svelte": "^4.0.5",
        "svelte-check": "^3.4.3",
        "svelte-migrate": "^1.2.3",
        "tslib": "^2.4.1",
        "typescript": "^5.0.0",
        "vite": "^4.4.3",
        "vite-imagetools": "^5.0.4"
    },
    "type": "module",
    "dependencies": {
        "@tiptap/core": "^2.0.3",
        "@tiptap/pm": "^2.0.3",
        "@tiptap/starter-kit": "^2.0.3",
        "prosemirror-example-setup": "^1.2.2",
        "prosemirror-model": "^1.19.3",
        "prosemirror-schema-basic": "^1.2.2",
        "prosemirror-schema-list": "^1.3.0",
        "prosemirror-state": "^1.4.3",
        "prosemirror-view": "^1.31.6",
        "svelte-tiptap": "^1.1.1"
    }
}

thank you :-)

Saul-Mirone commented 1 year ago

Just tried npm and pnpm, all works fine, maybe you can try to remove your node_modules and lock files before reinstall.

rchrdnsh commented 1 year ago

I tried that before...I'll try it again, though...

rchrdnsh commented 1 year ago

nope, did not work again for me...

I just did this:

npm install @prosemirror-adapter/svelte --force
npm WARN using --force Recommended protections disabled.
npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: @prosemirror-adapter/svelte@0.2.5
npm WARN Found: svelte@4.0.5
npm WARN node_modules/svelte
npm WARN   peer svelte@"^3.54.0 || ^4.0.0-next.0" from @sveltejs/kit@1.22.3
npm WARN   node_modules/@sveltejs/kit
npm WARN     peer @sveltejs/kit@"^1.0.0" from @sveltejs/adapter-auto@2.1.0
npm WARN     node_modules/@sveltejs/adapter-auto
npm WARN     1 more (the root project)
npm WARN   5 more (@sveltejs/vite-plugin-svelte, ...)
npm WARN 
npm WARN Could not resolve dependency:
npm WARN peer svelte@"^3.57.0" from @prosemirror-adapter/svelte@0.2.5
npm WARN node_modules/@prosemirror-adapter/svelte
npm WARN   @prosemirror-adapter/svelte@"*" from the root project
npm WARN 
npm WARN Conflicting peer dependency: svelte@3.59.2
npm WARN node_modules/svelte
npm WARN   peer svelte@"^3.57.0" from @prosemirror-adapter/svelte@0.2.5
npm WARN   node_modules/@prosemirror-adapter/svelte
npm WARN     @prosemirror-adapter/svelte@"*" from the root project

...and used --force but that is not a good thing, I would assume?

rchrdnsh commented 1 year ago

aw shucks, now I can't install anything:

npm install prosemirror-keymap
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @prosemirror-adapter/svelte@0.2.5
npm ERR! Found: svelte@4.0.5
npm ERR! node_modules/svelte
npm ERR!   peer svelte@"^3.54.0 || ^4.0.0-next.0" from @sveltejs/kit@1.22.3
npm ERR!   node_modules/@sveltejs/kit
npm ERR!     peer @sveltejs/kit@"^1.0.0" from @sveltejs/adapter-auto@2.1.0
npm ERR!     node_modules/@sveltejs/adapter-auto
npm ERR!       dev @sveltejs/adapter-auto@"^2.1.0" from the root project
npm ERR!     dev @sveltejs/kit@"^1.22.3" from the root project
npm ERR!   peer svelte@"^3.54.0 || ^4.0.0" from @sveltejs/vite-plugin-svelte@2.4.2
npm ERR!   node_modules/@sveltejs/vite-plugin-svelte
npm ERR!     @sveltejs/vite-plugin-svelte@"^2.4.1" from @sveltejs/kit@1.22.3
npm ERR!     node_modules/@sveltejs/kit
npm ERR!       peer @sveltejs/kit@"^1.0.0" from @sveltejs/adapter-auto@2.1.0
npm ERR!       node_modules/@sveltejs/adapter-auto
npm ERR!         dev @sveltejs/adapter-auto@"^2.1.0" from the root project
npm ERR!       1 more (the root project)
npm ERR!     peer @sveltejs/vite-plugin-svelte@"^2.2.0" from @sveltejs/vite-plugin-svelte-inspector@1.0.3
npm ERR!     node_modules/@sveltejs/vite-plugin-svelte-inspector
npm ERR!       @sveltejs/vite-plugin-svelte-inspector@"^1.0.3" from @sveltejs/vite-plugin-svelte@2.4.2
npm ERR!   4 more (@sveltejs/vite-plugin-svelte-inspector, svelte-hmr, ...)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer svelte@"^3.57.0" from @prosemirror-adapter/svelte@0.2.5
npm ERR! node_modules/@prosemirror-adapter/svelte
npm ERR!   @prosemirror-adapter/svelte@"^0.2.5" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: svelte@3.59.2
npm ERR! node_modules/svelte
npm ERR!   peer svelte@"^3.57.0" from @prosemirror-adapter/svelte@0.2.5
npm ERR!   node_modules/@prosemirror-adapter/svelte
npm ERR!     @prosemirror-adapter/svelte@"^0.2.5" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! 
npm ERR! For a full report see:
npm ERR! /Users/rchrdnsh/.npm/_logs/2023-07-16T17_32_19_156Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/rchrdnsh/.npm/_logs/2023-07-16T17_32_19_156Z-debug-0.log
rchrdnsh@RN lstv %

...while trying to instal prosemirror-keymap

Saul-Mirone commented 1 year ago

Please try @prosemirror-adapter/svelte@0.2.6

rchrdnsh commented 1 year ago

yup! worked like a charm, thank you! XD