Saulis / iron-data-table

iron-data-table is a Web Component for displaying data as a table or grid. Built on top of iron-list using Polymer.
Apache License 2.0
147 stars 66 forks source link

filter feature broke after hitting no result #158

Closed ashi009 closed 7 years ago

ashi009 commented 7 years ago

How to reproduce

  1. Go to https://saulis.github.io/iron-data-table/demo/filtering.html
  2. Scroll down the list (optional, but it will break for different reasons.)
  3. Input "ttttt"
  4. Now the iront-data-table is broken.

I didn't look too deep into this, and here are my findings:

Saulis commented 7 years ago

Thanks for the report!

There seems to be a check that fails when the returned size is falsey, can you try out if the branch fix/filter-zero-size fixes all the issues for you?

ashi009 commented 7 years ago

Thanks for the quick fix!

I've created a demo at http://jsbin.com/zisojebuge/edit?html,output, and it looks good!

ashi009 commented 7 years ago

Scratch that. I might have tested with wrong branch. Let me apply the patch to my project and see.

ashi009 commented 7 years ago

Yep, this fixed the issue!