search

Saulis / iron-data-table

iron-data-table is a Web Component for displaying data as a table or grid. Built on top of iron-list using Polymer.
Apache License 2.0
147 stars 66 forks source link

Add CSS variables for cell height #165

Closed davitykale-zz closed 7 years ago

davitykale-zz commented 7 years ago

Necessary for Shadow DOM

This change is Reviewable

Saulis commented 7 years ago

Hi and thanks! Would it be more useful if we add mixins for the cells instead? What do you think?

davitykale-zz commented 7 years ago

Sure! Either sounds good to me :)

On Wed, Nov 2, 2016 at 2:40 AM Sauli Tähkäpää notifications@github.com wrote:

Hi and thanks! Would it be more useful if we add mixins for the cells instead? What do you think?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Saulis/iron-data-table/pull/165#issuecomment-257816252, or mute the thread https://github.com/notifications/unsubscribe-auth/AEjMpE-BZBKY50WWKDmWNSr6bOXYDEUkks5q6FqkgaJpZM4Klq4E .

Saulis commented 7 years ago

Hi!

Sorry for the delay! Now that I actually looked more into this matter, what's actually the use case this? As you can currently just normally style:

iron-data-table data-table-cell {
  height: 100px;
}

Review status: 0 of 1 files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

Storyyeller commented 7 years ago

That doesn't work with the shadow dom.

Storyyeller commented 7 years ago

But https://github.com/Saulis/iron-data-table/pull/147 is more general, so I think you should go with that instead.

Storyyeller commented 7 years ago

In retrospect, I think this is useful independently of #147, since height has to be applied to both the checkbox and the cell, and we probably don't want the same mixin to apply to cell and checkbox.

Of course, that would require this to be modified to add the variables to checkbox as well.