search

Saulis / iron-data-table

iron-data-table is a Web Component for displaying data as a table or grid. Built on top of iron-list using Polymer.
Apache License 2.0
147 stars 66 forks source link

Improve `selecting` and `deselecting` event call #169

Closed NeilujD closed 7 years ago

NeilujD commented 7 years ago

I noticed that the selecting-item and the deselecting-item events were not fired when selecting by taping directly on the item associated checkbox. I also suggest to add a selecting-all event and a deselecting-all event.

This change is Reviewable

Saulis commented 7 years ago

Thanks!

This is a welcomed feature!

I'll do some finishing touches on it, add tests and rename selecting-all to selecting-all-items and deselecting-all to deselecting-all-items and merge it. :lgtm:

Reviewed 1 of 1 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

_Comments from Reviewable_