search

Saurabh3333 / give-me-a-joke

A npm-module for random and customized jokes.
https://www.npmjs.com/package/give-me-a-joke
MIT License
14 stars 10 forks source link

Change Requests To Axios #10

Closed ephraimduncan closed 3 years ago

ephraimduncan commented 4 years ago

Requests is deprecated and as it is working now, It may not in the near future. I think changing the major underlining requests library from request to axios is better.

Saurabh3333 commented 4 years ago

Would you like to contribute to it?

ephraimduncan commented 4 years ago

Sure, Axios uses promises and that makes it a bit complicated. I have cloned it and I am trying it out. I will get to you for review after.

ephraimduncan commented 4 years ago

I have opened the request. I am waiting for your review

Saurabh3333 commented 3 years ago

Merged. Thank you for your contribution. Let me know if you want to enhance this module in any way.