search

Saurabh3333 / give-me-a-joke

A npm-module for random and customized jokes.
https://www.npmjs.com/package/give-me-a-joke
MIT License
14 stars 10 forks source link

Change deprecated Request to Axios #11

Closed ephraimduncan closed 3 years ago

ephraimduncan commented 4 years ago

Request as opened an issue (#10) earlier on is deprecated. It is no longer maintained so I changed all the request requests to Axios which is a promise-based http client which is still maintained will be maintained for a long time.

Zaid-maker commented 3 years ago

Wow pretty nice dude

ephraimduncan commented 3 years ago

Thanks.

Zaid-maker commented 3 years ago

Yooo can we make same new package for quotes this would be cool.

Zaid-maker commented 3 years ago

@Saurabh3333 please merge it

Saurabh3333 commented 3 years ago

@Zaid-maker I have merged it. Please verify it once again and let me know. After that, I will release it.

Zaid-maker commented 3 years ago

Ok sure I am gonna test it

Zaid-maker commented 3 years ago

Yes you are good to go @Saurabh3333

Saurabh3333 commented 3 years ago

Thanks @Zaid-maker The new version is live now.

Zaid-maker commented 3 years ago

Ok