search

Saurabh3333 / give-me-a-joke

A npm-module for random and customized jokes.
https://www.npmjs.com/package/give-me-a-joke
MIT License
14 stars 10 forks source link

Joke.html #19

Closed Chandu2000 closed 3 years ago

Saurabh3333 commented 3 years ago

Can you please explain what have you done?

Chandu2000 commented 3 years ago

Hello! It's a Random Joke generator :)

On Thu, Oct 7, 2021, 8:36 PM Saurabh Shubham @.***> wrote:

Can you please explain what have you done?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Saurabh3333/give-me-a-joke/pull/19#issuecomment-937882797, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5DPLJCUH5ZL36A7LZCVTLUFWZOTANCNFSM5FRPY3YA .

Saurabh3333 commented 3 years ago

I can't see it.

Saurabh3333 commented 3 years ago

It will not merge if I can't see the real changes in action.

Chandu2000 commented 3 years ago

I created a new file. And it's a Random Joke creator.

On Thu, Oct 7, 2021, 8:52 PM Saurabh Shubham @.***> wrote:

It will not merge if I can't see the real changes in action.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Saurabh3333/give-me-a-joke/pull/19#issuecomment-937898606, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO5DPLLFMFCZQKFTNEAO7TDUFW3MLANCNFSM5FRPY3YA .

Saurabh3333 commented 3 years ago

Sorry! This will not be merged. How is it helping the module? 1000s people use it every week and how your change is going to help them? Please take some time and think about it.