Closed Abhisin90 closed 1 year ago
Hello @Abhisin90 The issue is not with the npm package but with the site it gets jokes from. You can verify it by having a look at the source code. As of Nov 4 2022, the site is down.
var giveMeAJoke = require("give-me-a-joke");
giveMeAJoke.getRandomDadJoke(function (joke) {
console.log(joke);
});
The above code will work fine because it gets jokes from some other site
it's just of the website is down not because of the pckage, if you try with Dadjokes it works fine, but with CNjokes it doesn't work
Do you guys want to contribute to make this package better? :-)
Hello @Saurabh3333.
To fix getRandomCNJoke
may I suggest using this API ?
The old API resource is not available anymore. If it's ok, I will submit a pull request
Go ahead.
Thank you, Regards Saurabh Shubham +91-9973286609 @.***
On Mon, 13 Mar, 2023, 3:21 am Igor Vilinchuk, @.***> wrote:
Hello @Saurabh3333 https://github.com/Saurabh3333. To fix getRandomCNJoke may I suggest using this API https://api.chucknorris.io/? The old API resource http://api.icndb.com/ is not available anymore. If it's ok, I will submit a pull request
— Reply to this email directly, view it on GitHub https://github.com/Saurabh3333/give-me-a-joke/issues/20#issuecomment-1465309032, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEY6OVP4TBYDZZN7FLFJF6LW3ZAO5ANCNFSM6AAAAAARSFGBDQ . You are receiving this because you were mentioned.Message ID: @.***>
Inside index.js i have written this code
const jokes = require('give-me-a-joke') console.dir(jokes) jokes.getRandomDadJoke((joke) => { console.log(joke) })
On running it
I am getting this output
Similarly on running
const jokes = require('give-me-a-joke') console.dir(jokes) jokes.getRandomCNJoke((joke) => { console.log(joke) })
my output comes this
Is there any problem from my end or yours. Kindly help. Thanks for the help in advance