search

Saurabh3333 / give-me-a-joke

A npm-module for random and customized jokes.
https://www.npmjs.com/package/give-me-a-joke
MIT License
14 stars 10 forks source link

actualizacion #4

Closed era5mx closed 4 years ago

era5mx commented 4 years ago

actualizacion

Saurabh3333 commented 4 years ago

Hey, Thank you for your contribution. Can you please explain to me your changes so than I can merge your request?

Saurabh3333 commented 4 years ago

@Zaid-maker Do you want to look into this PR? What do you think? Also, please loot at package-lock.json file. There are few security alert warnings. If its possible, please try to fix it. Lets make this npm-module, little bit more popular. :-)

Zaid-maker commented 4 years ago

Actually I don't know what does It mean. If you want you can.

On Tue, Mar 3, 2020, 11:51 AM Saurabh Shubham notifications@github.com wrote:

@Zaid-maker https://github.com/Zaid-maker Do you want to look into this PR? What do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Saurabh3333/give-me-a-joke/pull/4?email_source=notifications&email_token=AMXTCNDR6MKHMFEYFI5RYRTRFSSHLA5CNFSM4K3GNVKKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENSJ3OI#issuecomment-593796537, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMXTCNBYAQ5L233566N5Y63RFSSHLANCNFSM4K3GNVKA .

Saurabh3333 commented 4 years ago

@Zaid-maker I think, it is not important to merge this PR. Module is already working fine. Please look at the above comment again. I have updated it.

Zaid-maker commented 4 years ago

Of course why not i will surely 😊 do this.

Zaid-maker commented 4 years ago

@Saurabh3333 make sure to publish these changes to npm

Zaid-maker commented 4 years ago

@Saurabh3333 Is there an alternate request because request module is deprecated.

Saurabh3333 commented 4 years ago

@Zaid-maker I have not much idea. But our module is working fine now. Right?

Zaid-maker commented 4 years ago

Yes absolutely fine