Closed dysfunc closed 5 months ago
Do you know if this will work from code sandbox https://codesandbox.io/s/github/SauravKanchan/svelte-chartjs/tree/master/sandboxes/bar ?
Do you know if this will work from code sandbox https://codesandbox.io/s/github/SauravKanchan/svelte-chartjs/tree/master/sandboxes/bar ?
Oh, if you're going to link out then those files shouldn't change. Once you deploy the new version, that warning will go away about the missing exports.
Are you planning to treat this as a major release (v4.0.0
) since we modified bundling? If so, we could change the sandbox to reference ^4.0.0
now. Either way, these changes are no good since it requires installing the specific chartjs version.
@dysfunc good catch, I didn't think so because it was just the bundling folder which tools should pick up on. Is there anything I'm missing?
I think it's fine. It's just a way to control who receives the latest since they'll need to manually update the major, but I don't think that's needed.
I made the change that produces the smallest diff. You could also create an alias inside vite, but this does the same thing.