SauravMukherjee44 / Aec-Library-Website

This is an Open-Source Library Website in which you get Resources to learn different topics, Donate book section to donate your old books, and a Book issue section to keep a record of all the books issued. -HacktoberFest Accepted

https://aec-library-wbsite.netlify.app/

MIT License

105 stars 240 forks source link

Add validation in Signup and Signin form #1403

Closed Geeta259 closed 1 year ago

Geeta259 commented 1 year ago

🛠️ Fixes Issue

1379

👨‍💻 Changes proposed

Validation add for all empty fields Add red bottom border for empty field Add green bottom border for correct input Error message shown in top

✔️ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📷 Screenshots

Screenshot (494) Screenshot (495) Screenshot (496) Screenshot (497) Screenshot (498) Screenshot (499) Screenshot (500) Screenshot (501)

@rohanbabbar04 Please check it !! issue#1379 resolved

netlify[bot] commented 1 year ago

Deploy Preview for aec-library-wbsite ready!

Name	Link
Latest commit	17e7e53ed4ee1243bec8bf590208465022e2f669
Latest deploy log	https://app.netlify.com/sites/aec-library-wbsite/deploys/64a06717b46aaa0008dd5bd3
Deploy Preview	https://deploy-preview-1403--aec-library-wbsite.netlify.app/sign-up-page
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Geeta259 commented 1 year ago

Great Work :) Just one change can you set the default gender as male. Currently it is set to null it's better that we set it to some value...

@rohanbabbar04 Now check hope it works fine!!

rohanbabbar04 commented 1 year ago

This looks great @Geeta259 Thanks !