SauravMukherjee44 / Aec-Library-Website

This is an Open-Source Library Website in which you get Resources to learn different topics, Donate book section to donate your old books, and a Book issue section to keep a record of all the books issued. -HacktoberFest Accepted

https://aec-library-wbsite.netlify.app/

MIT License

105 stars 246 forks source link

Validation added on Book Donation Form issue#1207 resolved #1407

Closed Geeta259 closed 1 year ago

Geeta259 commented 1 year ago

🛠️ Fixes Issue

1207

👨‍💻 Changes proposed

Validations added on book donation form 1)Empty field validation on input fields and dropdown menus 2)Email validation add 3)contact no should be 10 digits 4)Default landmark and contact made required inputs 5)Error message shown below of each fields

✔️ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

Screenshot (519) Screenshot (520) Screenshot (521) Screenshot (522) Screenshot (523)

@rohanbabbar04 Please review it!!

netlify[bot] commented 1 year ago

Deploy Preview for aec-library-wbsite ready!

Name	Link
Latest commit	826301a170cca2288376a201d4862c182d009b48
Latest deploy log	https://app.netlify.com/sites/aec-library-wbsite/deploys/64a14c49b94e5b0008b5f24e
Deploy Preview	https://deploy-preview-1407--aec-library-wbsite.netlify.app/public/donate-book
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rohanbabbar04 commented 1 year ago

This looks great ! I would want the fields Landmark and Alternate Phone Number to be optional(NOT REQUIRED)