SauravMukherjee44 / Aec-Library-Website

This is an Open-Source Library Website in which you get Resources to learn different topics, Donate book section to donate your old books, and a Book issue section to keep a record of all the books issued. -HacktoberFest Accepted
https://aec-library-wbsite.netlify.app/
MIT License
106 stars 246 forks source link

Convert imges into Webp format #1408

Closed parasss19 closed 1 year ago

parasss19 commented 1 year ago

🛠️ Fixes Issue

1393

👨‍💻 Changes proposed

✔️ Check List (Check all the applicable boxes)

📄 Note to reviewers

netlify[bot] commented 1 year ago

Deploy Preview for aec-library-wbsite ready!

Name Link
Latest commit 9b35b75b856ec1ea20e251e86fca99bb76678d18
Latest deploy log https://app.netlify.com/sites/aec-library-wbsite/deploys/64acf250da7e520008173b68
Deploy Preview https://deploy-preview-1408--aec-library-wbsite.netlify.app/resource
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rohanbabbar04 commented 1 year ago

image In the above image, image is not displayed, it is working in the original Website, do correct it

parasss19 commented 1 year ago

Hey @rohanbabbar04 Now the logo images are visible please review it once

https://github.com/SauravMukherjee44/Aec-Library-Website/assets/101205226/918960b4-3649-4140-a884-af1dfdbee9f1

rohanbabbar04 commented 1 year ago

You have merge conflicts do resolve...

parasss19 commented 1 year ago

You have merge conflicts do resolve...

hey @rohanbabbar04 I resolved the conflict pls review it now

rohanbabbar04 commented 1 year ago

Thanks! As an extension , can you also replace the images which are broken, I think they don't look appealing and since you are already working on it would be better image To solve this either add new images or fix the old images, I'll leave that to you @parasss19

parasss19 commented 1 year ago

Thanks! As an extension , can you also replace the images which are broken, I think they don't look appealing and since you are already working on it would be better image To solve this either add new images or fix the old images, I'll leave that to you @parasss19

Hey @rohanbabbar04 I fixed all the images in resources page now all img are visible and i also removed the non working links of some youtube videos and image path and add the correct path Please review it

rohanbabbar04 commented 1 year ago

Thanks! Looks good to me