search

SauravMukherjee44 / Aec-Library-Website

This is an Open-Source Library Website in which you get Resources to learn different topics, Donate book section to donate your old books, and a Book issue section to keep a record of all the books issued. -HacktoberFest Accepted
https://aec-library-wbsite.netlify.app/
MIT License
105 stars 246 forks source link

fix: Fixed Semantic changes in Multiple HTML Files #1431

Closed NarendraKoya999 closed 1 year ago

NarendraKoya999 commented 1 year ago

🛠️ Fixes Issue

👨‍💻 Changes proposed

✔️ Check List (Check all the applicable boxes)

📄 Note to reviewers

📷 Screenshots

netlify[bot] commented 1 year ago

Deploy Preview for aec-library-wbsite ready!

Name Link
Latest commit 98810c7ba4d803270874a996a73187f01b442a8c
Latest deploy log https://app.netlify.com/sites/aec-library-wbsite/deploys/64bc0e3cf8ccc800083b1f48
Deploy Preview https://deploy-preview-1431--aec-library-wbsite.netlify.app/resource
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rohanbabbar04 commented 1 year ago

Issue no.??

NarendraKoya999 commented 1 year ago

Hi @rohanbabbar04 . This is Direct PR and It has no Issue No. At the starting of the GSSOC Program., I don't know First Create Issue and Then Create a New PR

rohanbabbar04 commented 1 year ago

Then can you explain it a little bit what change does it bring...

NarendraKoya999 commented 1 year ago

Then can you explain it a little bit what change does it bring...

Then can you explain it a little bit what change does it bring...

This is my What Changes Done Before and After Modifications

I have modified HTML5 Layout Errors in contributors.html File BEFORE Modification: <nav</nav> , 3 <div></div> sections in the <body></body> section in contributors.html Live Code :

<body>
   <nav></nav>
   <div></div>
  <div></div>
  <div><footer></footer></div>
</body>

AFTER Modification: <header></header>,<nav></nav>,<main></main>, 2 <section></section> tags added in contribution.html

<body>
  <header>
       <nav></nav>
  </header>
  <main>
     <section>
         <div></div>
    </section>
    <section>
         <div></div>
    </section>
  </main>
  <footer></footer>  // Remove <div></div>tag around the <footer></footer> section.
</body>
rohanbabbar04 commented 1 year ago

One question @NarendraKoya999 why only in contributors.html and not other files ?

NarendraKoya999 commented 1 year ago

One question @NarendraKoya999 why only in contributors.html and not other files ?

I have Individually raised a PR's for remaining Files Also. Kindly check @rohanbabbar04

rohanbabbar04 commented 1 year ago

What is the point of making seperate PR's for more or less the same issue, add all of them in this PR itself..

NarendraKoya999 commented 1 year ago

What is the point of making seperate PR's for more or less the same issue, add all of them in this PR itself..

At the Starting of the Program. I don't have Much Knowledge on How to Create PR's on Particular same relevant Issues

rohanbabbar04 commented 1 year ago

Don't worry Just add the semantic changes of all the files in this PR only...

And close other PRs(as you created for each file)

NarendraKoya999 commented 1 year ago

Don't worry Just add the semantic changes of all the files in this PR only...

And close other PRs(as you created for each file)

Ok. I can work on that. Removed unnecessary PR's and Changes adding in this PR and It's Branch

rohanbabbar04 commented 1 year ago

Yup, Sounds good to me Once done just request a review...

NarendraKoya999 commented 1 year ago

Yup, Sounds good to me Once done just request a review...

Hi @rohanbabbar04 . I completed All The Changes and Also I am Also Closed Other unnecessary PR's. Please Check and Review on It

rohanbabbar04 commented 1 year ago

Thanks I will review it soon....

NarendraKoya999 commented 1 year ago

Thanks I will review it soon....

Hi @rohanbabbar04 . Any Update on PR?. Please Review on this?

rohanbabbar04 commented 1 year ago

@NarendraKoya999 I'll review it over the weekend