SauravMukherjee44 / Aec-Library-Website

This is an Open-Source Library Website in which you get Resources to learn different topics, Donate book section to donate your old books, and a Book issue section to keep a record of all the books issued. -HacktoberFest Accepted
https://aec-library-wbsite.netlify.app/
MIT License
107 stars 248 forks source link

Added a typing effect on About us and Resources page #1446 #1446

Closed Arjundotadex closed 10 months ago

Arjundotadex commented 11 months ago

🛠️ Fixes Issue

Added a typing effect on the About Us and Resources page

👨‍💻 Changes proposed

✔️ Check List (Check all the applicable boxes)

📄 Note to reviewers

I have used js for the effect.

📷 Screenshots

image image

netlify[bot] commented 11 months ago

Deploy Preview for aec-library-wbsite ready!

Name Link
Latest commit b3341723efe5c3d25197d963f2d6e141a0dd5a27
Latest deploy log https://app.netlify.com/sites/aec-library-wbsite/deploys/64ba429bb52e0700083ac9b8
Deploy Preview https://deploy-preview-1446--aec-library-wbsite.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rohanbabbar04 commented 11 months ago

Remove .vscode/settings.json Also if I remember correctly there was a PR you made(I think you closed it), better to mention it over here, so that we could see if all the changes are covered...

Arjundotadex commented 11 months ago

Yeah, I closed that PR I created previously but have made similar changes in the new PR. I have deleted the file. Pls do check.

rohanbabbar04 commented 11 months ago

1302 - The PR you closed...

@Arjundotadex I don't really think adding effect to About Us and Courses makes sense. I think we should revert it back and instead add effect on the sub topics inside Courses like Web dev courses, App development courses, etc...

Arjundotadex commented 11 months ago

@rohanbabbar04 Alright got it!!