SauravMukherjee44 / Aec-Library-Website

This is an Open-Source Library Website in which you get Resources to learn different topics, Donate book section to donate your old books, and a Book issue section to keep a record of all the books issued. -HacktoberFest Accepted
https://aec-library-wbsite.netlify.app/
MIT License
105 stars 240 forks source link

Added the "alt" Property for Images #1456

Closed GauriBhandari closed 1 year ago

GauriBhandari commented 1 year ago

🛠️ Fixes Issue

Issue - #1455

👨‍💻 Changes proposed

Added the "alt" attribute to all images on the website. In this Pull Request, I have addressed the issue #1455 by adding the "alt" attribute to all images present on the website. The "alt" attribute provides alternative text for images, making the website more accessible for users with visual impairments.

✔️ Check List (Check all the applicable boxes)

netlify[bot] commented 1 year ago

Deploy Preview for aec-library-wbsite ready!

Name Link
Latest commit bc22bf57d34157255a251d31c209c9a3a87bd07a
Latest deploy log https://app.netlify.com/sites/aec-library-wbsite/deploys/64c3fffd88c5e20008bddfa9
Deploy Preview https://deploy-preview-1456--aec-library-wbsite.netlify.app/resource
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

GauriBhandari commented 1 year ago

Hello @rohanbabbar04 , @SauravMukherjee44 and team, I'm excited to contribute to the project and look forward to your review of this Pull Request. Let me know if any further adjustments are needed.

Thank you for considering these enhancements to improve website accessibility!

rohanbabbar04 commented 1 year ago

image

Some images seem to be broken do correct it :arrow_up:

GauriBhandari commented 1 year ago

Hello @rohanbabbar04 ,

I hope you're doing well. I wanted to provide an update on my Pull Request. I have addressed the issues raised during the review and fixed the broken images as suggested. Thank you for your valuable feedback, and I appreciate your time in reviewing my contributions. I'm looking forward to your re-evaluation of the updated Pull Request.

GauriBhandari commented 1 year ago

Hello @rohanbabbar04,

I hope you're doing well. I have made the necessary changes to address the broken images in the project. Could you please review my updated Pull Request?

GauriBhandari commented 1 year ago

Hello @rohanbabbar04 ,

I have made the necessary changes to address the broken images in the project. Could you please review my updated Pull Request?

rohanbabbar04 commented 1 year ago

Still I don't think its done. See link image

Wheras it should be image

GauriBhandari commented 1 year ago

Hello @rohanbabbar04 ,

I hope you're doing well. I have addressed the issues with broken images in my Pull Request. Could you kindly review my changes and consider merging the PR if everything looks good? I've tested the changes, to ensure that all images are now loading correctly. Your feedback is greatly appreciated. Thank you for your time and support!

GauriBhandari commented 1 year ago

Hello @rohanbabbar04 ,

I sincerely apologize for the inconvenience caused by the broken images in my previous Pull Request. I have revisited the issue, and I believe I have now correctly fixed the images. Could you kindly review my updated changes and consider merging the PR if everything looks good? Thank you for your understanding, and I appreciate your time and consideration.

GauriBhandari commented 1 year ago

Hello @rohanbabbar04 , I have made the necessary corrections to fix the broken images and cleaned up the code by removing the commented sections, as per your feedback.

Could you please review my updated Pull Request and consider merging the PR if everything looks good? Thank you for your understanding, and I appreciate your time and consideration.

rohanbabbar04 commented 1 year ago

Looks great.... Thanks

GauriBhandari commented 1 year ago

I hope all is well. I have restored the necessary code snippet and made the related changes accordingly. The code is now complete and ready for review. Thank you for your continued support and guidance throughout this process.

rohanbabbar04 commented 1 year ago

Thanks it looks good....