SauravMukherjee44 / Aec-Library-Website

This is an Open-Source Library Website in which you get Resources to learn different topics, Donate book section to donate your old books, and a Book issue section to keep a record of all the books issued. -HacktoberFest Accepted
https://aec-library-wbsite.netlify.app/
MIT License
107 stars 248 forks source link

Resolve issue 1475 sticky nav-bar #1482

Closed Manishak798 closed 11 months ago

Manishak798 commented 11 months ago

🛠️ Fixes Issue #1475

👨‍💻 Changes proposed

  1. Added CSS to make the Nav bar Sticky.
  2. Fixed a bug that caused content overlapping.
  3. Fixed sizes of hero elements.

✔️ Check List (Check all the applicable boxes)

📄 Note to reviewers

I resolve issue 1475, please let me know If you liked it, and do give your valuable review upon the same.

📷 Screenshots

image image

netlify[bot] commented 11 months ago

Deploy Preview for aec-library-wbsite ready!

Name Link
Latest commit 587a53e6146bc675df90d8bc52ba183a85e90e29
Latest deploy log https://app.netlify.com/sites/aec-library-wbsite/deploys/64cf08d52b5dc900088de337
Deploy Preview https://deploy-preview-1482--aec-library-wbsite.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rohanbabbar04 commented 11 months ago

You have merge conflicts do resolve...

Manishak798 commented 11 months ago

Can you tell me what kind of merge conflicts are?

Manishak798 commented 11 months ago

Hey @rohanbabbar04 I resolved the conflicts, please check my PR.

rohanbabbar04 commented 11 months ago

For desktop it looks great, but would also need it to work for different screen sizes. Look :point_down: image

Manishak798 commented 11 months ago

Okie, I will work on that and submit this to you by tomorrow. But can you tell me should I close this PR then?

rohanbabbar04 commented 11 months ago

No, you can commit to this branch only let it continue

Manishak798 commented 11 months ago

hey @rohanbabbar04 , I have applied media queries accordingly please check. image

Manishak798 commented 11 months ago

Hey @rohanbabbar04, Please check my PRs, let me known your views about the same.

Manishak798 commented 11 months ago

@rohanbabbar04 kindly check my PR.

Manishak798 commented 11 months ago

@rohanbabbar04 Please check my PR, and let me know what you think about it.

Manishak798 commented 11 months ago

Hey @rohanbabbar04 please check my PRs.

Manishak798 commented 11 months ago

Hey @rohanbabbar04 , I hope you are doing well, kindly check my PR, it's a request to you.

rohanbabbar04 commented 11 months ago

Hi @Manishak798, sorry I have been a little busy over the last two days... I will review it today or tomorrow...

Manishak798 commented 11 months ago

No worries @rohanbabbar04 take your time.

Manishak798 commented 11 months ago

Hey @rohanbabbar04 , Kindly check my PR and let me know your views on the same.

rohanbabbar04 commented 11 months ago

For desktop it looks great, but would also need it to work for different screen sizes. Look 👇 image

Still this problem is there...

Manishak798 commented 11 months ago

Kindly tell me in which screen resolutions this is showing up..

rohanbabbar04 commented 11 months ago

Check Here, haven't tested it locally but this is not showing for any smaller screen sizes

Manishak798 commented 11 months ago

Hey @rohanbabbar04, according to your concerns I performed retesting of my code and also checked the link you provided me on my mobile phone, It is working seamlessly, I have also inspected the website on different resolutions available on Chrome, and too gave me the accurate result. I am providing you the screenshot below and I highly insist you to please text it out locally or tell me the accurate resolution where you are seeing this error. image

Manishak798 commented 11 months ago

Hey @rohanbabbar04 I have made the changes accordingly, found the bug and I resolved it, Please check this out now. image

rohanbabbar04 commented 11 months ago

Now, it looks good :D Thanks @Manishak798

Manishak798 commented 11 months ago

You're welcome, @rohanbabbar04.