Closed Manishak798 closed 11 months ago
Name | Link |
---|---|
Latest commit | 587a53e6146bc675df90d8bc52ba183a85e90e29 |
Latest deploy log | https://app.netlify.com/sites/aec-library-wbsite/deploys/64cf08d52b5dc900088de337 |
Deploy Preview | https://deploy-preview-1482--aec-library-wbsite.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
You have merge conflicts do resolve...
Can you tell me what kind of merge conflicts are?
Hey @rohanbabbar04 I resolved the conflicts, please check my PR.
For desktop it looks great, but would also need it to work for different screen sizes.
Look :point_down:
Okie, I will work on that and submit this to you by tomorrow. But can you tell me should I close this PR then?
No, you can commit to this branch only let it continue
hey @rohanbabbar04 , I have applied media queries accordingly please check.
Hey @rohanbabbar04, Please check my PRs, let me known your views about the same.
@rohanbabbar04 kindly check my PR.
@rohanbabbar04 Please check my PR, and let me know what you think about it.
Hey @rohanbabbar04 please check my PRs.
Hey @rohanbabbar04 , I hope you are doing well, kindly check my PR, it's a request to you.
Hi @Manishak798, sorry I have been a little busy over the last two days... I will review it today or tomorrow...
No worries @rohanbabbar04 take your time.
Hey @rohanbabbar04 , Kindly check my PR and let me know your views on the same.
For desktop it looks great, but would also need it to work for different screen sizes. Look 👇
Still this problem is there...
Kindly tell me in which screen resolutions this is showing up..
Check Here, haven't tested it locally but this is not showing for any smaller screen sizes
Hey @rohanbabbar04, according to your concerns I performed retesting of my code and also checked the link you provided me on my mobile phone, It is working seamlessly, I have also inspected the website on different resolutions available on Chrome, and too gave me the accurate result. I am providing you the screenshot below and I highly insist you to please text it out locally or tell me the accurate resolution where you are seeing this error.
Hey @rohanbabbar04 I have made the changes accordingly, found the bug and I resolved it, Please check this out now.
Now, it looks good :D Thanks @Manishak798
You're welcome, @rohanbabbar04.
🛠️ Fixes Issue #1475
👨💻 Changes proposed
✔️ Check List (Check all the applicable boxes)
📄 Note to reviewers
I resolve issue 1475, please let me know If you liked it, and do give your valuable review upon the same.
📷 Screenshots