SauveJeanLuc / coffee-tasks

Next gen AI Powered Todo-List
https://coffeetasks.netlify.app
MIT License
38 stars 73 forks source link

feat(UI): delete, change status, edit tasks #119

Closed adi-uchiha closed 1 year ago

adi-uchiha commented 1 year ago

Closes #85

Description

Related Issue

85

Motivation and Context

How Has This Been Tested?

Checklist:

Screenshots (if appropriate):

netlify[bot] commented 1 year ago

Deploy Preview for coffeetasks ready!

Name Link
Latest commit b1293ab49569511cab4d904c4bc9bcff56dd88b1
Latest deploy log https://app.netlify.com/sites/coffeetasks/deploys/6347db6c229e6a00091bc2b6
Deploy Preview https://deploy-preview-119--coffeetasks.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

SauveJeanLuc commented 1 year ago

Edit is creating a new task instead

SauveJeanLuc commented 1 year ago

The two buttons should remain. Only that, you will replace Create Task by Edit Task. image

adi-uchiha commented 1 year ago

Yup I see that there is a logical mistake done by me. It can be fixed easily. And I will add back the cancel button as well.

adi-uchiha commented 1 year ago

@SauveJeanLuc hey I just checked. I think it is working fine. Edit task is NOT creating new tasks. Tho I will add a commit to put the cancel button next to edit button. edit task is working fine. I checked in deployment preview => https://deploy-preview-119--coffeetasks.netlify.app/

SauveJeanLuc commented 1 year ago

@SauveJeanLuc hey I just checked. I think it is working fine. Edit task is NOT creating new tasks. Tho I will add a commit to put the cancel button next to edit button. edit task is working fine. I checked in deployment preview => https://deploy-preview-119--coffeetasks.netlify.app/

I mean, When I press enter.

SauveJeanLuc commented 1 year ago

Also, position well the Edit and Cancel Buttons as the ones for Creation are Positioned.

SauveJeanLuc commented 1 year ago

There is an unnecessary blue border background when typing in the react select. Screenshot (44)

adi-uchiha commented 1 year ago

@SauveJeanLuc is it ok now ?

SauveJeanLuc commented 1 year ago

@SauveJeanLuc is it ok now ?

  • [x] Edit task when press enter
  • [x] Edit and cancel button are positioned just like the addtask and cancel button were.
  • [x] Removed the blue border in dropdown search
  • [x] made code more readable by adding one extra component src/components/Todo.jsx

Blue border is still there.

SauveJeanLuc commented 1 year ago

These words should be updated as well. image

SauveJeanLuc commented 1 year ago

Pull from master and resolve conflicts

SauveJeanLuc commented 1 year ago

The Blue border is still there

Even for the all Inputs.

Screenshot (45)

adi-uchiha commented 1 year ago

@SauveJeanLuc unable to fix that. Moreover I tried copy pasting the code of old commits (When there was not blue border). still the bluebox appears on new code. I did not even changed the code of <SelectButton /> component. I think we should merge this and create a new issue for this. PS: You can close this PR if this is not getting merged. Nomore commits on this PR from my side. Looking forward to work on another issue. also, what about making a slack or discord for better community bonding

SauveJeanLuc commented 1 year ago

Great @adi-uchiha Let's have it merged. And you can raise an issue for it.

Here's an invite to discord: https://discord.gg/GzpQyMGz

SauveJeanLuc commented 1 year ago

@all-contributors add @adi-uchiha for code

allcontributors[bot] commented 1 year ago

@SauveJeanLuc

@adi-uchiha already contributed before to code