Closed adi-uchiha closed 1 year ago
Name | Link |
---|---|
Latest commit | b1293ab49569511cab4d904c4bc9bcff56dd88b1 |
Latest deploy log | https://app.netlify.com/sites/coffeetasks/deploys/6347db6c229e6a00091bc2b6 |
Deploy Preview | https://deploy-preview-119--coffeetasks.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
Edit is creating a new task instead
The two buttons should remain.
Only that, you will replace Create Task by Edit Task.
Yup I see that there is a logical mistake done by me. It can be fixed easily. And I will add back the cancel button as well.
@SauveJeanLuc hey I just checked. I think it is working fine. Edit task is NOT creating new tasks. Tho I will add a commit to put the cancel button next to edit button. edit task is working fine. I checked in deployment preview => https://deploy-preview-119--coffeetasks.netlify.app/
@SauveJeanLuc hey I just checked. I think it is working fine. Edit task is NOT creating new tasks. Tho I will add a commit to put the cancel button next to edit button. edit task is working fine. I checked in deployment preview => https://deploy-preview-119--coffeetasks.netlify.app/
I mean, When I press enter.
Also, position well the Edit and Cancel Buttons as the ones for Creation are Positioned.
There is an unnecessary blue border background when typing in the react select.
@SauveJeanLuc is it ok now ?
src/components/Todo.jsx
@SauveJeanLuc is it ok now ?
- [x] Edit task when press enter
- [x] Edit and cancel button are positioned just like the addtask and cancel button were.
- [x] Removed the blue border in dropdown search
- [x] made code more readable by adding one extra component
src/components/Todo.jsx
Blue border is still there.
These words should be updated as well.
Pull from master and resolve conflicts
The Blue border is still there
Even for the all Inputs.
@SauveJeanLuc unable to fix that. Moreover I tried copy pasting the code of old commits (When there was not blue border). still the bluebox appears on new code. I did not even changed the code of <SelectButton />
component. I think we should merge this and create a new issue for this.
PS: You can close this PR if this is not getting merged. Nomore commits on this PR from my side.
Looking forward to work on another issue.
also, what about making a slack or discord for better community bonding
Great @adi-uchiha Let's have it merged. And you can raise an issue for it.
Here's an invite to discord: https://discord.gg/GzpQyMGz
@all-contributors add @adi-uchiha for code
@SauveJeanLuc
@adi-uchiha already contributed before to code
Closes #85
Description
Related Issue
85
Motivation and Context
How Has This Been Tested?
Checklist:
] I have added tests that prove my fix is effective or that my feature works
Screenshots (if appropriate):