Closed rodrigoodev closed 1 year ago
Name | Link |
---|---|
Latest commit | 31e385540b65c07fe4eb1c899aa63732f56a91f9 |
Latest deploy log | https://app.netlify.com/sites/coffeetasks/deploys/634c6017dd25af0009fd7123 |
Deploy Preview | https://deploy-preview-142--coffeetasks.netlify.app/ |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
@rodrigoodev Can you use both screenshots to help spot changes you've made ?
@rodrigoodev I think it's better the way it was, and the Figma has to be corrected instead.
WDYT ?
hello @SauveJeanLuc here a print of master
the padding not matching with figma in master, i correct this padding the non-aligned padding was annoying me :smile:
@rodrigoodev I think it's better the way it was, and the Figma has to be corrected instead.
WDYT ?
If you think scruffy looks better ok, but it goes against nielsen's law
nielsen's law
Interesting, could you tell us more about the Nielsen's law ? It might help us take the decision.
Here is a link about heuristics of NIelsen, In this case, I'm talking about the alignment between the container divs, when padding is applied to the div, misalignment happens, which causes discomfort in design.
If it climbed, it could turn into an accordion effect.
for example the image below
if you don't have a design knowledge, it's ok to keep the page structure like this, and it's quite normal when you're starting and you don't have a sense of standardization that you can't see these details in smaller design, as is the case with our whole list.
Now look at the difference when we apply Nielsen's law 4, law of organization and standardization.
You feel the lighter design, right?
now, putting the designs next to each other, you will get a better feeling of looking at the design on the right.
So basically that's why my PR.
Now feel free to decide which one you think is best.
Great, Idea accepted. Pull from master and I'll merge
Check #62
Closes #141
Description
Matching to layout figma
Checklist:
Screenshots (if appropriate):