search

SavageCore / node-ffprobe-installer

Platform independent binary installer of FFprobe for node projects
https://www.npmjs.com/package/@ffprobe-installer/ffprobe
72 stars 29 forks source link

[darwin-arm64] Update binaries #248

Closed wongyiuhang closed 1 year ago

wongyiuhang commented 1 year ago

As discussed in https://github.com/SavageCore/node-ffprobe-installer/pull/200#issuecomment-1110834244, a new version of ffprobe on darwin-arm64 is compiled.

@JuanIrache, may you help and confirm the new binary extracts rotation before we merge the update? Thank you🙏

ffprobe(5.1.2)

JuanIrache commented 1 year ago

I will run some tests and get back to you. Thank you!

wongyiuhang commented 1 year ago

@SavageCore, in this PR, I have bumped the NPM package version from 5.0.1 to 5.1.2, which reflects the ffprobe version. Is that okay? Or shall I change back to 5.1.0, which aligns with other architecture package versions?

SavageCore commented 1 year ago

No problem, the versions are essentially useless as they are now, at least this one will have meaning :)

JuanIrache commented 1 year ago

@JuanIrache, may you help and confirm the new binary extracts rotation before we merge the update? Thank you🙏

Orientation works great, thank you! This binary does not exactly work for my use case, as it does not include things like libxcb and libSDL2 statically (typically included in static binaries like these), but I suppose that's beyond the scope of this project.