SavageCore / node-ffprobe-installer

Platform independent binary installer of FFprobe for node projects
https://www.npmjs.com/package/@ffprobe-installer/ffprobe
72 stars 29 forks source link

Added TypeScript Types #250

Closed cseitz closed 1 year ago

cseitz commented 1 year ago

The following changes mirror what is being done to generate types in @ffmpeg-installer/ffmpeg

Utilizes tsc and JSdoc types to generate types. npm run types is added to the precommit hook and to package.json's prepare script.

SavageCore commented 1 year ago

This looks great after an initial look, thank you. Please give me a few days to merge, work is rather hectic!

codecov-commenter commented 1 year ago

Codecov Report

Merging #250 (85a6213) into master (148cb8b) will decrease coverage by 0.36%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   88.23%   87.87%   -0.36%     
==========================================
  Files           2        2              
  Lines          34       33       -1     
==========================================
- Hits           30       29       -1     
  Misses          4        4              
Impacted Files Coverage Δ
index.js 85.18% <ø> (-0.53%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

xxRockOnxx commented 1 year ago

@SavageCore just in case you forgot, pinging you about this.

SavageCore commented 1 year ago

@SavageCore just in case you forgot, pinging you about this.

Thanks for the ping, I did. Will get this sorted over the weekend!