SavageCore / pd3-vault-cracker

Generates vault code possibilities from fingerprints
https://savagecore.github.io/pd3-vault-cracker/
GNU General Public License v3.0
9 stars 2 forks source link

[Obsolete] Allow multiple presses of same number #19

Closed todd-pd closed 1 year ago

todd-pd commented 1 year ago

Context

When viewing a keypad, sometimes there are fewer than four digits that have fingerprints. When this occurs, it means that at least one of the fingerprinted digits has been pressed twice.

It's also possible for one of the fingerprints to appear "bolder" than the others. I took that to mean that the "bolder" fingerprint was the digit that occurred twice.

For example, compare the fingerprint on number 6 to those on 0 and 5:

locked

I concluded that the code would therefore be some combination of 0566.

Assuming this theory about the bolder fingerprint always held true, it would be beneficial to allow those four digits to be entered into the keypad cracker, since it would lead to fewer valid permutations, therefore fewer combinations to guess.

Changes

I started making changes to enable multiple presses of the same button (both visually and logically). I got as far as having everything working, and was starting to add tests.

Plot twist

I then thought "it'd be useful to have screenshots for the pull request, just to prove that this theory works". So I restarted a heist a few times until I got a "3 digit" keypad (the 056 keypad pictured above).

But sadly, the actual code was 0556. The doubled up digit was 5, not 6. The bold fingerprint actually doesn't make a difference.

unlocked

Conclusion

Maybe the bold fingerprint should matter, and maybe the fact that it doesn't currently matter is a bug. Maybe these changes will be useful in future. Maybe not.

But since I got it working, I figured it was worth having a PR just for archival purposes.

If it's ever useful or is worth resurrecting then the tests still need updating.

todd-pd commented 1 year ago

@SavageCore The theory was incorrect so this isn't much use, but thought you might be interested in the journey.

SavageCore commented 1 year ago

Love it! Thanks for the contribution anyway. You might be right and it's currently bugged, maybe we'll see on the 5th.