search

SavageLabs / SavageFactions

The Ultimate Competitve Factions Plugin. Switches focus from casual factions and introduces new features for competitive factions.
https://savagelabs.net
GNU General Public License v3.0
95 stars 63 forks source link

Placeholder {group} #191

Closed srleojaco closed 5 years ago

srleojaco commented 5 years ago

Describe the bug In toopltips.show there is a placeholder called {group} for showing player's rank. It seems it doesnt work image

To Reproduce Steps to reproduce the behavior:

  1. Go to 'config.yml and check toopltips.show'
  2. Issue command '.f who [fac]..'
  3. Move mouse to faction members
  4. See error

Expected behavior Should shown player group

Screenshots If applicable, add screenshots to help explain your problem. image

Server VErsion (please complete the following information):

SvenjaReissaus commented 5 years ago

Te referis a mostrar el "Rango", (i.e: Leader, Co-Leader, Mod, etc)?

SvenjaReissaus commented 5 years ago

Please notice the comment, it requires Vault to be installed. # {group} will show the players primary group if you have vault installed.

srleojaco commented 5 years ago

I've "Vault" installed so it's not problem. Previously i was using factionsuuid and it showed the "permissions rank" for example: vip, admin, mod, vip2, vip3

MinerSpigot12 commented 5 years ago

It's an issue with the latest set of updates. He changed some code which broke it. If you have built off the source code, feel free to follow these instructions. If not, report this to him and wait for an update.

Broken SavageFactions Code: http://prntscr.com/oqbf2i

Fixed Code: http://prntscr.com/oqbf60

prosavage commented 5 years ago

That is correct we were trying to mess with atomics

srleojaco commented 5 years ago

So it will be fixed?

MinerSpigot12 commented 5 years ago

Yes, most likely.

Savag3life commented 5 years ago

Update to the latest version. If the issue persists, please reopen or resubmit :)

Thanks, Illyria Team