PR for fly and other minor issues

SvenjaReissaus commented 4 years ago

What type of PR is this?

This PR provides a fixes to minor issues that has been stuck at the issues section, as well as the latest issue related to faction fly.

Relevant links of issues for this PR.

Faction Fly Issue #252 Check it out here (By @Sandor)
F fly bug, players can fly outside of claimed land #246
Faction fly error being spammed in console #244 (Only another workaround, since @Keeeeezay already pushed the fix for it yesterday)
Can't allow spawners to be broken by non faction members #239
You are not the faction admin error #221

As well as:

Faction fly not being disabled once away from faction territory.
Faction fly not being disabled after unclaim of land.
Faction fly would persist once faction disband.

Explained changes

Faction fly was being enabled/disabled here and there, now most of it is being handled from the checkCanFly method, being called once and only when the task is executed, and disabled fly on faction disband and faction unclaim.
A new check to determine if BLOCK or SPAWNER permission should be used at break/place events, so that the SPAWNER permission actually works.
A pre-check to allow OP/bypass to actually work against certain commands using CommandRequirements.

Why did I made this changes

It's ma job. And also because of the old issues that were actually easy to fix but still weren't, and multiple reports in the support discord about faction bypass not doing it's thing, as well as latest reports with the fly issue, thanks to [@Sandor#4559]() that provided me with all the information needed in order to solve the issue.

Compatibility issues

Not as far as I could tell, however, there's a PR merge issue, since I started working on this earlier yesterday, before the latest push, so it brings up a conflict within the PlayerEventListener.java file, since the modified method on the main branch was as well modified by me, although, the remote changes were taken and included in this PR.

SvenjaReissaus commented 4 years ago

Changes can be previewed at server itproaser.com.

prosavage commented 4 years ago

Clear the conflicts then?

SvenjaReissaus commented 4 years ago

@ProSavage this branch has no conflicts with the primary branch

SavageLabs / SavageFactions