search

SavageLearning / Machete

A web application for managing a day laborer referral organization. Built using .NET Core MVC, Entity Framework Core, jQuery, Datatables (datatables.net).
GNU General Public License v3.0
16 stars 17 forks source link

Error message when trying to delete a worker #468

Open motaylorvoz opened 5 years ago

motaylorvoz commented 5 years ago

This is what was reported by Graton. They are unable to delete a worker from a data basis and it results in Error!

chaim1221 commented 5 years ago

Steps to repro:

  1. do to people tab 2. choose a worker, 3. push delete on profile page....results in error
chaim1221 commented 5 years ago

image

chaim1221 commented 5 years ago

So this is by design but I'm not closing it because the error message doesn't give the user any idea what is happening. A worker with assignments or signins cannot be deleted.We can't cascade because of reporting purposes. If the worker was actually signed in or assigned, they should not be deleted. They can be expired, sanctioned, or expelled.

chaim1221 commented 5 years ago

This has not been fixed and actually it's gotten worse. Now it doesn't even say that there was an error trying to delete the worker.

What we really need to implement is "soft delete."

esteban-gs commented 4 years ago

I propose we close this issue. This may be a permissions issue.

When I attempt to recreate with a manager role, when I push delete and accept, it does nothing (record is not deleted), and system does not let me know that I don't have enough permissions. image

When I attempt to recreate with a manager role, delete works.

chaim1221 commented 4 years ago

yes the "doesn't let me know" is the reason I kept it open, see comment above.

chaim1221 commented 4 years ago

Unassigning myself as I am not actively working on this. Additionally if it's not blocking centers then it's really a v2 consideration, not a v1 one.