search

Savagedlight / libifconfig

A C API to do most things done by the FreeBSD 'ifconfig' program today
Other
26 stars 7 forks source link

libifconfig_get_description(): Confusing code #33

Open Savagedlight opened 8 years ago

Savagedlight commented 8 years ago

Investigate if the following section of code is necessary:

} else if (ifr.ifr_buffer.length > descrlen) {
    descrlen = ifr.ifr_buffer.length;
    continue;
}

I think this tells the next ioctl() call to allocate a larger buffer for the name, but this needs digging into how the SIOCGIFDESCR ioctl() call is implemented.