SavandBros / whisper

Whisper chat for me, myself and I
GNU General Public License v3.0
5 stars 0 forks source link

Login and signup design #42

Closed AmirSavand closed 6 years ago

AmirSavand commented 6 years ago

Issues

Screenshots

Login

Clean

image

With error

image

Sign up

Clean

image

With error

image

New font

image

New background for sign up and login

image

New design

image

codecov[bot] commented 6 years ago

Codecov Report

Merging #42 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #42   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files          22       22           
  Lines         428      428           
=======================================
  Hits          405      405           
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4bd072b...cbd561e. Read the comment docs.

Alir3z4 commented 6 years ago

Have a look at django allauth documentation. Regarding overdding login template.

On Thu, May 24, 2018, 19:06 Amir Savand notifications@github.com wrote:

Assigned #42 https://github.com/SavandBros/whisper/pull/42 to @Alir3z4 https://github.com/Alir3z4.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/SavandBros/whisper/pull/42#event-1644671919, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkFCV21lbjRKaRi9DWE9P5OJF3xrcn6ks5t1tqQgaJpZM4UMjCO .

AmirSavand commented 6 years ago

I did override it but it didn't work at all. Do this when you can no rush.

Alir3z4 commented 6 years ago

@AmirSavand is says you have to override account/login.html template

For instance, the view corresponding to the account_login URL uses the template account/login.html. If you create a file with this name in your code layout, it can override the one shipped with allauth. -- https://django-allauth.readthedocs.io/en/latest/templates.html#overridable-templates

AmirSavand commented 6 years ago

I found that registration/login.html will do the trick, ok I will try account/login.html.

Alir3z4 commented 6 years ago

registration/login.html is useful when using django-registration app. We're using Django Allauth and that uses different location. You can just remove registration/login.html file completely

On Fri, May 25, 2018 at 12:20 AM Amir Savand notifications@github.com wrote:

I found that registration/login.html will do the trick, ok I will try account/login.html.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SavandBros/whisper/pull/42#issuecomment-391866975, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkFCWvLYcAXz-6f01gMQ6pV1fZwZFI5ks5t1yQkgaJpZM4UMjCO .

AmirSavand commented 6 years ago

Yes.

AmirSavand commented 6 years ago

@Alir3z4 let me add sign up too.

AmirSavand commented 6 years ago

@Alir3z4 how to modify /accounts/confirm-email/ template?

Alir3z4 commented 6 years ago

@Alir3z4 how to modify /accounts/confirm-email/ template?

This should be in the documentation as well. Check the docs and let let me know

However, we can do that later right ? If this pull request is ready, let's merge and move on

AmirSavand commented 6 years ago

I checked the github repo, I changed the template name, tried many things but didn't work, I think it should be set.

Anyway, I will ignore it for now, and make this ready to merge soon.

Alir3z4 commented 6 years ago

The design is really nice. Great job on this.

Alir3z4 commented 6 years ago

by the way you may find them at https://django-allauth.readthedocs.io/en/latest/advanced.html#sending-email

AmirSavand commented 6 years ago

image

@Alir3z4 no the design was just plain bootstrap 4, here's a simple modification (10 lines of css)

AmirSavand commented 6 years ago

@Alir3z4 this pull request is ready to be merged.

Alir3z4 commented 6 years ago

Nice and dice <3 Lovely

On Sat, May 26, 2018 at 10:57 PM Amir Savand notifications@github.com wrote:

[image: image] https://user-images.githubusercontent.com/4629328/40579770-8ed094d0-6140-11e8-8bb0-4abd4dedcc3d.png

@Alir3z4 https://github.com/Alir3z4 no the design was just plain bootstrap 4, here's a simple modification (10 lines of css)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SavandBros/whisper/pull/42#issuecomment-392284661, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkFCRiyym9OAibpzwnlvilurxwMJ9X1ks5t2bPDgaJpZM4UMjCO .

Alir3z4 commented 6 years ago

Great job. I've merged Will see how it is on the staging server.

keep up the great work!

On Sat, May 26, 2018 at 10:58 PM Amir Savand notifications@github.com wrote:

@Alir3z4 https://github.com/Alir3z4 this pull request is ready to be merged.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SavandBros/whisper/pull/42#issuecomment-392284721, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkFCS-QPyAtfdeaQoE_pYQ2h08xchLbks5t2bP3gaJpZM4UMjCO .