SavandBros / whisper

Whisper chat for me, myself and I
GNU General Public License v3.0
5 stars 0 forks source link

Fix convert #58

Closed AmirSavand closed 6 years ago

AmirSavand commented 6 years ago

Emoji support via unicodes:

image

Fix linkify:

image

codecov[bot] commented 6 years ago

Codecov Report

Merging #58 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files          22       22           
  Lines         428      428           
=======================================
  Hits          405      405           
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8ef5ce...5f8f71e. Read the comment docs.

Alir3z4 commented 6 years ago

So in order to insert emojis we have to click on that emoji icon to open the pan and select one ? I was thinking of not having that emoji pan and simply just typing and getting them, you know what I mean ?

AmirSavand commented 6 years ago

This is the easiest and cleanest way currently.

Again, we need to predefine all the shortcuts for the emojis and simply convert them, but even then we still need this selection since every app has it.

BTW a simple setting can disable it and it is disabled for mobile since mobile keyboard has emojis.

Alir3z4 commented 6 years ago

It would be much nicer to have this pan/list come up when typing :

AmirSavand commented 6 years ago

That should be a way smaller auto complete type of thing (minimal). This is a simple structure that can be easily upgraded with more features, like search bar which is already there by AngularJS (searching ng-repeat).