search

SavandBros / whisper

Whisper chat for me, myself and I
GNU General Public License v3.0
5 stars 0 forks source link

[WIP] Video Call #60

Open Alir3z4 opened 6 years ago

Alir3z4 commented 6 years ago

Fixes #59

There's https://github.com/bahmutov/ng-simple-webrtc as well

codecov[bot] commented 6 years ago

Codecov Report

Merging #60 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   94.62%   94.62%           
=======================================
  Files          22       22           
  Lines         428      428           
=======================================
  Hits          405      405           
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4efe4da...4685e9b. Read the comment docs.

AmirSavand commented 6 years ago

@Alir3z4 what do you think we should do about this? If we can't even get it working, I don't want this to be merged.

Alir3z4 commented 6 years ago

No don't get this merged. For now let it stay here until we get back to it later. Don't need to do anything about it for now. Let's get back on master and improve the current stable version

On Tue, Jun 19, 2018 at 9:51 AM Amir Savand notifications@github.com wrote:

@Alir3z4 https://github.com/Alir3z4 what do you think we should do about this? If we can't even get it working, I don't want this to be merged.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SavandBros/whisper/pull/60#issuecomment-398293431, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkFCV58_uTT4SElB-wa19yXgn5dm9A3ks5t-J93gaJpZM4Upy2v .