search

SaveScum / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project
0 stars 0 forks source link

Very slow saving after editing ESM flag #108

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
Download More Interactive Items http://skyrim.nexusmods.com/mods/3562

Start TES5Edit and select only More Interactive Items.ESM.
Go to the File Header section for More Interactive Items.ESM and remove the ESM 
flag.
Exit TES5Edit and save (I had make backups turned off, not sure if it matters).

Start TES5Edit again and select only More Interactive Items.ESM.
Go to the File Header section for More Interactive Items.ESM and re-add the ESM 
flag.
Exit TES5Edit and save.

What is the expected output?
File saved in a timely manner.

What do you see instead?
TES5Edit works very, very, VERY slowly at saving the file.

What version of the product are you using? On what operating system?
TES5Edit 3.0.28. Windows 7 64-bit.

Please provide any additional information below.
More Interactive Items.ESM was likely created with the use of TESVSnip.

Original issue reported on code.google.com by executor...@hotmail.com on 11 Feb 2013 at 5:19

GoogleCodeExporter commented 9 years ago 
It was not created by snip.
New code added to support VMAD in 3.0.28 has some serious performance issues, 
you can feel it for example when browsing quests group in skyrim.esm. Yes VMAD 
subrecords are huge and take time to parse, but should not be the reason for 
such major slowdown. Now it feels like 10x times slower... :(

Original comment by zila...@gmail.com on 11 Feb 2013 at 7:35

GoogleCodeExporter commented 9 years ago 
Running a profiling, but out of debugging it took ~20 minutes, during debugging 
and with profiling it has run for 45 minutes and it is not done.

Original comment by HuguesLe...@gmail.com on 11 Feb 2013 at 10:55

GoogleCodeExporter commented 9 years ago 
Finally took 54 minutes. At first glance, I would say I need to optimize 
MergeStorage...

Original comment by HuguesLe...@gmail.com on 11 Feb 2013 at 11:09

Attachments:

GoogleCodeExporter commented 9 years ago 
Tried with 3.0.27 (prior to vmad update) and it halts too. Why the hell noone 
ever noticed that performance issue in the past.
The only logical answer is because More Interactive Items.ESM overrides around 
10000 of vanilla references, which is unheard even for large mods or dlcs.

Original comment by zila...@gmail.com on 12 Feb 2013 at 6:20

GoogleCodeExporter commented 9 years ago 
If I don't "MemorySort" etSubRecord, etSubRecordStruct, etSubRecordUnion, 
etStruct, etValue, etFlag, etStringListTerminator and etUnion I am down to ~1' 
in debugger.

If I add back etSubRecord to the sorted elements, it rises up to more than 30' !

Original comment by HuguesLe...@gmail.com on 19 Feb 2013 at 10:08

GoogleCodeExporter commented 9 years ago 
The reason for this is because switching an ESP to an ESM will trigger the 
generation of the ONAM subrecords when the file is saved. This has been a 
normal and accepted cause for the delay in the past, though perhaps something 
is greatly slowing it down for Skyrim.

Something to look at anyway.

Original comment by arthmoor on 26 Feb 2013 at 3:07

GoogleCodeExporter commented 9 years ago 
executor115@hotmail.com : Did you try with 3.0.29 ?
Hoping to close...

Original comment by HuguesLe...@gmail.com on 20 Mar 2013 at 8:31

GoogleCodeExporter commented 9 years ago 
Yeah, definitely saving very quickly now. Problem resolved, thank you.

Original comment by executor...@hotmail.com on 1 Apr 2013 at 4:05

GoogleCodeExporter commented 9 years ago

Original comment by HuguesLe...@gmail.com on 1 Apr 2013 at 7:20