SaveScum / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project
0 stars 0 forks source link

Memory allocation error #134

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Copy any element with model to a new plugin, for example 00000F55 
<defaultBlankTrigger>
2. Add Model element, then add MODS inside
3. Try to add a new entry in MODS.

What is the expected output?
MODS with an empty alternate texture.

What do you see instead?
First, adding MODS should already create a new empty alternate texture.
Second, adding new texture causes <Error: Expected 4 bytes of data, found 0>

What version of the product are you using? On what operating system?
3.0.30, Win7 x64

Please provide any additional information below.
Reminds me of similar bug when adding new conditions in previous version.
Also happends in other similar subrecords, for example (Fe)Male world 
model\MO2S in ARMO.

Original issue reported on code.google.com by zila...@gmail.com on 8 Jun 2013 at 6:46

GoogleCodeExporter commented 9 years ago
Argh! Not this again :)

Original comment by HuguesLe...@gmail.com on 8 Jun 2013 at 11:43

GoogleCodeExporter commented 9 years ago
It's not so bad, I can modify existing ones and save them :)

Original comment by zila...@gmail.com on 8 Jun 2013 at 4:16

GoogleCodeExporter commented 9 years ago
Check 3.0.29, identical issue. Went back to 3.0.28.
So the same issue with having to add twice before seeing something is true, but 
at least 3.0.28 left you with something you could modify !

I am going to check what we changed between 3.0.28 and 3.0.29.

Original comment by HuguesLe...@gmail.com on 8 Jun 2013 at 5:53

GoogleCodeExporter commented 9 years ago
Can you confirm that saving and reloading between adding the Model and adding 
the MODS entry removes the issue for you also? When you create the MODS array 
does'nt seem to count.

Original comment by HuguesLe...@gmail.com on 16 Jun 2013 at 12:42

GoogleCodeExporter commented 9 years ago
As for the real issue, it looks to be a conflict between providing storage for 
default values of newly created structures, and not creating phantom storage 
for inexistent data. So, I need to find a mechanism to tell the creator if it 
is a new form which should get storage for default values.

I introduced a DefaultSize property so I can properly workaround that.

Original comment by HuguesLe...@gmail.com on 16 Jun 2013 at 3:22

GoogleCodeExporter commented 9 years ago
Corrected as of r1345

Original comment by HuguesLe...@gmail.com on 16 Jun 2013 at 4:01

GoogleCodeExporter commented 9 years ago
Thanks, will test it later.
However we have a new problem :(
https://code.google.com/p/skyrim-plugin-decoding-project/issues/detail?id=135

Original comment by zila...@gmail.com on 16 Jun 2013 at 5:26

GoogleCodeExporter commented 9 years ago
Assuming fixed.

Original comment by HuguesLe...@gmail.com on 5 Jul 2013 at 2:17