SaveScum / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project
0 stars 0 forks source link

XIBS and ONAM, subrecords of REFR, are being treated as ignore for ITM #137

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.set the 'ignored by sandbox' in a reference, save the plugin
2.Clean the plugin
3.your changes are gone
4.With 'open by default', the record won't be removed by cleaning, but the ONAM 
is not flagged as changed (yellow)

What is the expected output?
Show as changed fields

What do you see instead?
ITM - see screenshot 
https://dl.dropboxusercontent.com/u/55759080/Tes5Edit/XIBS-ONAM.JPG

What version of the product are you using? On what operating system?
FNVEdit version 3.0.30

Please provide any additional information below.

Original issue reported on code.google.com by rickerhk...@gmail.com on 3 Jul 2013 at 5:50

GoogleCodeExporter commented 9 years ago
This is what I get from editing those 2 properties in the GECK only.

Only the flags are set!

Though, I don't know where the GESK stores the info about "Ignore by Sandbox" 
it is still present after a "remove ITM"

Original comment by HuguesLe...@gmail.com on 3 Jul 2013 at 8:48

Attachments:

GoogleCodeExporter commented 9 years ago
I understand better. XIBS is a flag field. It does not have any data, it is 
just present or not.

Original comment by HuguesLe...@gmail.com on 3 Jul 2013 at 9:02

GoogleCodeExporter commented 9 years ago
I changed the sortkey for a non existing record to an arbitrary value rather 
than '' wich ended up being a valid key in some cases.

Original comment by HuguesLe...@gmail.com on 3 Jul 2013 at 11:06

GoogleCodeExporter commented 9 years ago
I'm for overriding ToEditValue() of TwbEmpty and returning "<Empty>" instead 
unless you sure that changing sortkey won't affect anything else. Any non 
wbEmpty element which is added/removed but has no value must be treated as ITM, 
for example subrecords that contain texture/model path.

Original comment by zila...@gmail.com on 3 Jul 2013 at 11:24

GoogleCodeExporter commented 9 years ago
I went that way first, but then I realized it COULD be a valid avllue. Now 
did'nt I added the empty sort key just for what you said? Let's take the safe 
route...

Original comment by HuguesLe...@gmail.com on 3 Jul 2013 at 11:36

GoogleCodeExporter commented 9 years ago
I didn't know where you added sortkey, there were no svn updates when I wrote 
my comment. I was afraid that you added sortkey for all empty string values, 
not only wbEmpty :)

Original comment by zila...@gmail.com on 3 Jul 2013 at 12:10

GoogleCodeExporter commented 9 years ago
Should be more explicit this way :)

Original comment by HuguesLe...@gmail.com on 3 Jul 2013 at 12:26

GoogleCodeExporter commented 9 years ago
I think this can be closed.

Original comment by zila...@gmail.com on 20 Jan 2014 at 8:56

GoogleCodeExporter commented 9 years ago
I agree :)

Original comment by HuguesLe...@gmail.com on 20 Jan 2014 at 9:00