SaveScum / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project
0 stars 0 forks source link

TESxEdit allows generation of new files beyond the FE form ID index. #174

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Generate a folder full of plugins. Mass copying the names of existing ones 
will do for this test.
2. Activate them all using whatever mod manager is desired.
3. Manually edit the plugins.txt file to exceed the 255 hard limitation.
4. Load Edit with this plugins.txt file in place.
5. Do a record override from any chosen plugin file into a NEW FILE.

What is the expected output?
Expect the program to deny generating the file due to the index exceeding FE.

What do you see instead?
Program generated a file with the FF index, then a second one with 100 as the 
index. This behavior is entirely invalid and should not be allowed.

Should be noted that once these files are generated, Edit doesn't want to deal 
with them in any meaningful way except to correctly inform the user that 
they're invalid.

Original issue reported on code.google.com by arthmoor on 26 Sep 2014 at 10:14

GoogleCodeExporter commented 9 years ago
Should be fixed as part of r1833 and later.

Original comment by HuguesLe...@gmail.com on 16 Oct 2014 at 10:24

GoogleCodeExporter commented 9 years ago
It's sort of fixed. Trying to load the program with more than you should have 
yields this:

[Skyrim.esm] Loading file
[Skyrim.esm] File loaded
[Skyrim.esm] Start processing
[00:00] Background Loader: starting...
[00:00] Background Loader: Too many plugins selected. Adding 256 would exceed 
the maximum index of 254
[00:02] Background Loader: finished

It should instead be deactivating the extra mods so the program will continue 
to load, but not have the extra files.

Doing overrides into new files is still allowing them to get generated for FF, 
100, 101, etc which should NOT be happening.

The "New File" option should be prevented from showing up at all if it would 
cause the index to go above FE.

Original comment by arthmoor on 17 Oct 2014 at 8:37

GoogleCodeExporter commented 9 years ago
I purposely chose not to load anything if you are going over the limit, as 
there is no point loading 256 plugins if the one that matter gets skipped 
because it comes later. Better have the user select the ones he wants.

For the other ways to increase plugin index, I did forgot about them.

Original comment by HuguesLe...@gmail.com on 20 Oct 2014 at 11:05

GoogleCodeExporter commented 9 years ago
Check r1843 when available

Original comment by HuguesLe...@gmail.com on 29 Oct 2014 at 10:47