SaveScum / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project
0 stars 0 forks source link

Can't save changes in NIFZ list #189

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. FNVEdit: add any new value in NIFZ list of CREA for example
2. save
3. reload

What is the expected output?
Added new value

What do you see instead?
No new value
<Warning: Unused data in:  \ [01] 11111.esp \ [1] GRUP Top "CREA" \ [0] 
CrRobobrainEnclave "Robobrain" [CREA:0001CF74] \ [7] NIFZ - Model List>

What version of the product are you using? On what operating system?
r1893

Please provide any additional information below.
Looks like we broke something while fixing counter effects list for Oblivion :(

Original issue reported on code.google.com by zila...@gmail.com on 6 Feb 2015 at 6:13

GoogleCodeExporter commented 9 years ago
I am seeing the same thing in 3.0.32

Original comment by HuguesLe...@gmail.com on 6 Feb 2015 at 7:37

GoogleCodeExporter commented 9 years ago
Really? It is actually RoyBatty from TTW site reported it, and said it started 
with some latest versions. Strange.

Original comment by zila...@gmail.com on 6 Feb 2015 at 9:02

GoogleCodeExporter commented 9 years ago
Also in 3.031. Did not check earlier versions :)
Hopefully I can look at it tomorrow.

Original comment by HuguesLe...@gmail.com on 6 Feb 2015 at 10:55

GoogleCodeExporter commented 9 years ago
The new string is appended to the string array after the final double zero, not 
in the middle of it.

Original comment by HuguesLe...@gmail.com on 9 Feb 2015 at 1:10

GoogleCodeExporter commented 9 years ago
I guess it affects only null terminated array of strings?

Original comment by zila...@gmail.com on 9 Feb 2015 at 4:41

GoogleCodeExporter commented 9 years ago
KFFZ does the same, and it seems Creature are the only records to use 
wbStringLC.
So I should check an array of wbString

Original comment by HuguesLe...@gmail.com on 10 Feb 2015 at 11:15

GoogleCodeExporter commented 9 years ago
Works with static arrays of strings of given length (IMPF). I did not see 
another array of zero terminated strings in FNV or TES4.

Original comment by HuguesLe...@gmail.com on 10 Feb 2015 at 11:26

GoogleCodeExporter commented 9 years ago
It looks like, when the storage is updated/invalidated the 
IwbStringListTerminator is not sorted as the last element to allocate, which 
could point to the memory order sort I added a few years ago.

Original comment by HuguesLe...@gmail.com on 10 Feb 2015 at 12:45

GoogleCodeExporter commented 9 years ago
Yes that was it. We have to enforce the terminator is the last element in 
memory.
Fix uploaded later.

Original comment by HuguesLe...@gmail.com on 10 Feb 2015 at 1:05

GoogleCodeExporter commented 9 years ago
Thanks!

Original comment by zila...@gmail.com on 10 Feb 2015 at 2:27

GoogleCodeExporter commented 9 years ago
fixed in r1896

Original comment by HuguesLe...@gmail.com on 10 Feb 2015 at 6:28

GoogleCodeExporter commented 9 years ago

Original comment by HuguesLe...@gmail.com on 11 Feb 2015 at 10:56