FNVEdit bug when using "Copy as Override" on some dialogs

[GoogleCodeExporter]

What steps will reproduce the problem?
1. With FNVEdit loads the FalloutNV.ESM file
2. Go to the "Dialog Topics" section
3. Select a dialog topic with a PNAM - Previous INFO record
4. Right-click and try to "Copy as Override" into another file
5. When FNVEdit asks the user if FalloutNV.esm should be added to the masters 
list of the other file, select "Yes"

What is the expected output?

FNVEdit should properly copy as override the dialog into the second file

What do you see instead?

For some dialogs (I don't have found which factor is the most important) 
FNVEdit doesn't copy the PNAM - Previous INFO record, associating with a null 
reference (NULL - Null Reference [00000000])which can corrupt the file.

A user explained how to avoid the problem to me on the Nexus :

"Your assumption about Previous Info is correct. What I do is delete all of the 
Previous Info in the Dialog INFOs before I copy them over, this leaves them 
blank. I then copy them over and promptly save the file. FNVEdit 3.0.21 will 
then reassign Previous Info to those Dialog INFOs I have stripped of their 
Previous Info. The reason for the corruption is that there is a hidden chain of 
reference information based on Previous Info, and coping them with their 
Previous Info attached will cause the program to trip over it's own feet and 
fail to copy the record right. "

What version of the product are you using? On what operating system?

FNVEdit 3.0.21

Original issue reported on code.google.com by geobo...@gmail.com on 4 Oct 2012 at 8:05

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

That user on the nexus who explained that was me: Kuroitsune. I would like to 
be referenced when quoted in the future. I'd also like to know where you found 
that quote - I know I wrote it, but don't remember where.

Original comment by harkness...@yahoo.com on 16 Oct 2012 at 1:31

[GoogleCodeExporter]

From the FNVEdit Issue Depot thread: 
http://forums.nexusmods.com/index.php?/topic/715413-fnvedit-issue-depot-bug-repo
rts/

Original comment by danielhmpdx16@gmail.com on 16 Oct 2012 at 2:26

[GoogleCodeExporter]

Thank you good sir. I knew I wrote that but I was damned to remember where I 
wrote it. This particular bug this issue covers is still present in 3.0.22. 
When working on dialogue, I can accurately predict what the Previous Info of 
the INFO will be, but the program refuses to save the file, throwing an 
assertion error. I can go back to that particular INFO and delete its Previous 
Info, and the program will save the file. I look up that INFO again and lo and 
behold the program has written a Previous INFO to that particular INFO, and it 
was the same one I had manually added. I think a good work around for this bug 
is to make the program delete the Previous INFO when the user copies the INFO 
into another file, and let the program rewrite the Previous INFO when the file 
is saved, or force the program to rewrite that INFO's PNAM after it is copied.

Original comment by harkness...@yahoo.com on 16 Oct 2012 at 9:31

[GoogleCodeExporter]

Please post here a test plugin and give instructions what FormIDs to 
delete/alter to prevent that plugin from saving.

Original comment by zila...@gmail.com on 17 Oct 2012 at 5:23

[GoogleCodeExporter]

DialogFail.esp

The only three records in it are dialog, specifically during char-gen with doc 
mitchell. Select all three -> copy as override -> new file.

Using 3.0.22 it wrecks itself every time, throws an assertion error, creates 
weird blank dialogue in the new file.

Original comment by kyleco...@gmail.com on 20 Oct 2012 at 6:31

Attachments:

• DialogueFail.esp

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Error while copying [INFO:00107223] ('It's important that you're relaxed for 
this next test. Please, have a seat.' in GRUP Topic Children of GREETING 
"GREETING" [DIAL:000000C8] for VCG01 "Ain't That a Kick in the Head" 
[QUST:00104C1C]): Assertion failure (D:\Projects\TES5Edit\wbImplementation.pas, 
line 10641)

Original comment by kyleco...@gmail.com on 20 Oct 2012 at 7:12

[GoogleCodeExporter]

Thanks, fixed.
Just a note: this error occured due to a sorting method of INFO records inside 
DIAL group (First comes INFOs with PNAM equal to NULL, next comes with PNAM 
linked to previous INFO, at the end INFOs without PNAM). FNVEdit also tried to 
add appropriate PNAMs to INFOs without it. I disabled all of this so now it 
will load/save DIAL groups as is without alterations.
I don't know how things work in FNV, you'll probably need to test and see 
yourself when the new version is out.
Please report results later so I can close this issue.

Original comment by zila...@gmail.com on 20 Oct 2012 at 9:44

• Changed state: Started

[GoogleCodeExporter]

Thank you very much. Any idea when the next build will be completed?

Original comment by kyleco...@gmail.com on 20 Oct 2012 at 3:36

[GoogleCodeExporter]

I'm having this issue this morning. Seems like the problem is occurring when a 
previous info is not the immediate info just above, when sorting by FormID - 
which should be allowed because you can re-order infos for a topic in the Geck, 
so FormID order should not matter.
So having xEdit assume that the plugin has the correct PNAM info seems like the 
way to go.
Unless the PNAM is MISSING - then xEdit should add them. This would allow 
repairs to be done and merge multiple plugins that add infos to the same topics 
in a master plugin

Original comment by rickerhk...@gmail.com on 21 Oct 2012 at 6:16

[GoogleCodeExporter]

Fixed in 3.0.23

Original comment by zila...@gmail.com on 31 Oct 2012 at 4:21

• Changed state: Fixed