SaveScum / skyrim-plugin-decoding-project

Automatically exported from code.google.com/p/skyrim-plugin-decoding-project
0 stars 0 forks source link

Removing a copied as override record removes the whole tree associated with it #88

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I ran into a serious bug.

- open a mod with a quest in it, i.e. something that has the Quest tree already 
populated
- copy as override a quest from Skyrim.esm into the mod
- immediately remove the copied record this way: right click on the mod name at 
the top right of the screen, select remove and confirm deletion without doing 
anything else in between

Ta-da, the entire quest tree is gone from the mod. It's not just a matter of 
visualization, the tree is really gone. Save the mod and reload it and you'll 
see for yourself. Might affect other record types as well.

Original issue reported on code.google.com by dab...@email.it on 9 Dec 2012 at 9:49

GoogleCodeExporter commented 9 years ago
Confirmed with the above steps. It also doesn't matter where the quests are 
sourced from for testing.

Original comment by arthmoor on 9 Dec 2012 at 9:59

GoogleCodeExporter commented 9 years ago
Does it happen with FNVEdit 3.0.21?

Original comment by zila...@gmail.com on 10 Dec 2012 at 5:41

GoogleCodeExporter commented 9 years ago
FNVEdit 3.0.22 appears to work as expected. Only the one quest is removed.

Original comment by arthmoor on 10 Dec 2012 at 5:54

GoogleCodeExporter commented 9 years ago
FO3Edit 3.0.25 also seems to work properly.

Original comment by arthmoor on 10 Dec 2012 at 6:00

GoogleCodeExporter commented 9 years ago
Hmm tried to reproduce in 3.0.26, but failed
1) Opened Skyrim.esm and Unofficial Skyrim Patch.esp
2) copied a quest from skytim to uskp
3) immediately removed it
4) quest tree is still there in uskp

Original comment by zila...@gmail.com on 10 Dec 2012 at 6:11

GoogleCodeExporter commented 9 years ago
WTF, I swear when I went to verify this last night it did exactly what was 
said, and now I can't reproduce it either. Even with 3.0.27.

Not the kind of bug one likes to see since it's the kind of thing that could 
rise up again later.

Original comment by arthmoor on 10 Dec 2012 at 7:20

GoogleCodeExporter commented 9 years ago
If 2 people encountered it, then a bug is definitely there. Perhaps it requires 
some additional actions/conditions to reproduce.

Original comment by zila...@gmail.com on 10 Dec 2012 at 8:04

GoogleCodeExporter commented 9 years ago
I couldn't tell you what though. When I checked it all I did was load Edit, 
copy a quest as an override into the USKP, remove it by using the column header 
at top right, and then noting that the entire Quest branch was gone.

Gremlins.

Original comment by arthmoor on 10 Dec 2012 at 8:23

GoogleCodeExporter commented 9 years ago
I can't reproduce it either with Arthmoor's Live Another Life mod but it's 
consistent with my own mod [still not published, couldn't link] which has 
several masters [skyrim.esm, update.esm, dawnguard.esm, hearthfires.esm and all 
the ESMified unofficial patches], perhaps the condition is how many masters the 
mod has? Just a wild guess though.

Original comment by dab...@email.it on 10 Dec 2012 at 3:18

GoogleCodeExporter commented 9 years ago
It is possible.
But I haven't changed anything regarding records/groups deletion, so if that 
bug is there, it probably should exist in original versions of TES4Edit 3.0.15, 
FO3Edit, etc.

Original comment by zila...@gmail.com on 10 Dec 2012 at 3:34

GoogleCodeExporter commented 9 years ago
Ok I found the condition. Apparently you have to do it TWICE for the bug to 
fire up. The very first time you copy the quest and remove it by using the 
column header TES5Edit works as intended. If, however, you do the same a 2nd 
time it removes the entire Quest branch. So, the detailed steps for anyone 
willing to give this a try are as follows:

1) open TES5Edit
2) select whatever mod with some quests in it [the USKP is just fine]
3) click OK and wait for the mod to be loaded
4) in the left panel expand the Skyrim.esm branch
5) expand the Quest branch
6) right click a quest, select "Copy as override into.." and confirm with Yes 
at the Warning
7) select Unofficial Skyrim Patch and click OK
8) right click on the USKP column header, select Remove and confirm with Yes
9) in the left panel scroll down to the USKP, the Quest branch should be still 
there
10) repeat the steps from 4 to 8 [you don't have to select the same quest form 
as before]

The USKP Quest branch is now gone.

But wait, it gets worse. If you do the above another time the ENTIRE mod is 
gone.

I tried the above with several mods and TES5Edit always acts the same. I'd 
raise the issue priority as High.

dAb

Original comment by dab...@email.it on 10 Dec 2012 at 8:50

GoogleCodeExporter commented 9 years ago
I might add that the bug is reproducible even if you don't open a mod with 
quests, you just have to select skyrim.esm at the TES5Edit start and copy as 
override a few quests into a new file, then do the copy as override/remove step 
using the newly created file and the quest branch is gone from it. Doesn't seem 
to affect other record types though.

dAb

Original comment by dab...@email.it on 10 Dec 2012 at 9:15

GoogleCodeExporter commented 9 years ago
Can't reproduce the updated scenario either.

Original comment by arthmoor on 10 Dec 2012 at 9:21

GoogleCodeExporter commented 9 years ago
I'm shocked. I'm sure I didn't miss any step. I did it one more time just to be 
really sure, carefully following the steps above and the bug fires up as usual. 
I don't have any other programs running who might interfere. No idea, really.

Original comment by dab...@email.it on 10 Dec 2012 at 9:36

GoogleCodeExporter commented 9 years ago
Me either, because when I verified it initially, I saw the USKP's quest branch 
disappear. So it happened. It just isn't cooperating with being reproduced.

I normally don't remove stuff that way anyway (actually didn't know you could) 
so I've never had the misfortune of this happening to me.

Original comment by arthmoor on 10 Dec 2012 at 10:23

GoogleCodeExporter commented 9 years ago
I don't usually remove stuff this way either, I just happened to stumble upon 
the issue while I was copying a few specific quests into my mod and I once 
clicked the wrong one, so I thought I could just remove it by using the column 
header, then when I saved the work and loaded it into the CK to my great 
surprise all my quests were gone. Good thing I had backups. I really don't know 
what to think, funny thing is I'm not able to prevent the bug from firing up 
anymore, it always happens on my end, no matter what. As you said, Gremlins.

dAb

Original comment by dab...@email.it on 10 Dec 2012 at 10:36

GoogleCodeExporter commented 9 years ago
So, the bug is there, and most likely have been there since TES4Edit. Still, 
until I can reproduce it myself, it'll be very hard to find the cause.

Original comment by zila...@gmail.com on 11 Dec 2012 at 6:02

GoogleCodeExporter commented 9 years ago
I too have noticed this happening. I need to see if I can reproduce it and come 
back with my own steps, but it seems to happen to more categories than just 
Quests. I have a hunch it might have to do with having records filtered...?

Original comment by kyleco...@gmail.com on 14 Jan 2013 at 11:39

GoogleCodeExporter commented 9 years ago
This have been worked around in the official release by removing the 
functionality.
Keeping the issue open in the hope that someone finds a reliable way to 
reproduce the bug.

Original comment by HuguesLe...@gmail.com on 5 Jul 2013 at 2:24