SaveryIV / SaveryIV.github.io

In this project we are parsing a Figma template of a Portfolio and making it responsive
MIT License
4 stars 0 forks source link

Github Pages Deploy #11

Open SaveryIV opened 1 year ago

SaveryIV commented 1 year ago

-Changing the sizing of the viewport -Fixing size and responsive background -Link site: https://saveryiv.github.io/

skyv26 commented 1 year ago

Hi @SaveryIV,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

STATUS: REQUIRE CHANGES 🔴

Highlights

Required Changes ♻️

Your README project deployment section

Screenshot from 2023-05-08 16-46-09

Your README section should look like this

image

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag @skyv26 in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

codewithmike01 commented 1 year ago
codewithmike01 commented 1 year ago

Hi studentName,

STATUS: APPROVED 🟢

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

TO HIGHLIGHT:

Suggestion

well-1

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.