SavingGoogleCode / tint2

tint2 is a lightweight panel/taskbar.
GNU General Public License v2.0
0 stars 0 forks source link

Google Hangouts icon causing whitespace in tint2 #464

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Install Google Chrome with hangouts addon.
2. Check that you have the hangouts icon in the taskbar and just use normally 
for a few hours.

What is the expected output? What do you see instead?
When you see the hangouts icon in the taskbar whitespace starts to be added to 
the hangout icon at random and ultimately it fills the bar squashing everything.

What version of the product are you using? On what operating system?
tint2 0.11~svn649-1
CrunchBang 11 Waldorf, based on Debian GNU/Linux 7.8 (wheezy)
3.16.0-0.bpo.4-amd64 #1 SMP Debian 3.16.7-ckt2-1~bpo70+1 (2014-12-08) x86_64 
GNU/Linux

Please provide any additional information below.
Some screenshots taken by another user I found in searching the web can be seen 
here http://crunchbang.org/forums/viewtopic.php?pid=414444#p414444

Original issue reported on code.google.com by nicho...@alipaz.net on 5 Feb 2015 at 10:01

GoogleCodeExporter commented 9 years ago
Thanks, we will look into it.

Original comment by mrovi9...@gmail.com on 5 Feb 2015 at 11:29

GoogleCodeExporter commented 9 years ago
Reproducible:

1. Use Google Chrome with the Hangouts addon 
https://chrome.google.com/webstore/detail/hangouts/nckgahadagoaajjgafhacjanaoiih
apd/related?hl=en
2. In the Hangouts popup, right click on the arrow near the top chat bar, go to 
more options, disable system tray icon.
3. Same thing, but this time enable it --> white space appears. The old tray 
window is not unmapped (it still shows the Hangouts tooltip).

xfce-panel handles it correctly.

Original comment by mrovi9...@gmail.com on 6 Feb 2015 at 8:38

GoogleCodeExporter commented 9 years ago
As far as I can see, Chrome never sends a DestroyNotify (neither a 
DestroyNotify) event, thus the old icon gets stuck in the system tray.

All I can catch is a ConfigureNotify event in which the tray window resizes 
itself from 22x22 to 200x200.

Not sure yet how xfce-panel manages to hide it.

I have also tried:
* wmsystemtray 1.4
* stalonetray 0.8.0

which both exhibit the problem.

Original comment by mrovi9...@gmail.com on 6 Feb 2015 at 10:04

GoogleCodeExporter commented 9 years ago
Probably related to 
https://code.google.com/p/chromium/issues/detail?id=419673#c28

Original comment by mrovi9...@gmail.com on 6 Feb 2015 at 11:54

GoogleCodeExporter commented 9 years ago
Good find on the google chromium issue queue.  I can confirm that my wife's 
computer is using xfce and it does not exhibit this issue.

Original comment by nicho...@alipaz.net on 6 Feb 2015 at 4:11

GoogleCodeExporter commented 9 years ago
LXPanel (from LXDE) has the same issue.

Testing is easier using this page:

https://developer.mozilla.org/en-US/docs/Web/API/Notification/Using_Web_Notifica
tions#Simple_example

Scroll a bit lower and click the "Notify me!" button.

Original comment by mrovi9...@gmail.com on 6 Feb 2015 at 5:28

GoogleCodeExporter commented 9 years ago
mrovi9, I am also able to see the problem when clicking "Notify me!" on that 
page, each notification seems to increase the whitespace surrounding the 
notification icon.

Original comment by nicho...@alipaz.net on 11 Feb 2015 at 11:13

GoogleCodeExporter commented 9 years ago
Closing this since it is a Google Chrome bug. I tried to find a workaround 
without success.

Please follow/post further comments in 
https://code.google.com/p/chromium/issues/detail?id=419673

Original comment by mrovi9...@gmail.com on 19 Mar 2015 at 2:40

GoogleCodeExporter commented 9 years ago
It is fine by me that this is closed.  I just recently found more information 
that points to this being an issue in either xfce4-power-manager or the 
xfce4-power-manager's battery applet.  Supposedly disabling 
xfce4-power-manager's battery applet will solve it.  However, I never tried 
because I have gotten a new machine and am on jessie where xfce4-power-manager 
no longer includes an applet.

Original comment by nicho...@alipaz.net on 19 Mar 2015 at 6:02

GoogleCodeExporter commented 9 years ago
(writing here because I don't see any way to CC you from GitLab)

Actually I am sure it has nothing to do with xfce4-power-manager. Chrome has 
the same problem on LXDE with LXPanel.

As the Chrome devs have not shown any interest in fixing this frustrating 
issue, I reopened the bug and wrote a workaround in tint2. Basically what it 
does is:
* when drawing the icon, it detects that the image is empty; if it is empty, it 
moves it to the end of the system tray;
* when creating a new icon, it checks the process that creates it. If the same 
process owns another icon that was marked as empty, the old icon is deleted 
from the system tray.

I pushed the change to the master branch in GitLab. You can find instructions 
on getting the source code from there and compiling here: 
https://gitlab.com/o9000/tint2/wikis/Install#getting-the-sources

If there are no reported side effects, the change will be included in the next 
stable release, to be released in 1-2 months.

Original comment by mrovi9...@gmail.com on 11 May 2015 at 7:29

GoogleCodeExporter commented 9 years ago
I responded on gitlab: https://gitlab.com/o9000/tint2/issues/464

Original comment by nicho...@alipaz.net on 12 May 2015 at 4:21