search

SavingGoogleCode / tint2

tint2 is a lightweight panel/taskbar.
GNU General Public License v2.0
0 stars 0 forks source link

Code cleanup #468

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
* Refactor large functions into smaller ones
* Rename variables that do not have intuitive names
* Use a consistent coding style

With a lot of care not to break anything.

Original issue reported on code.google.com by mrovi9...@gmail.com on 8 Feb 2015 at 9:12

GoogleCodeExporter commented 9 years ago

Original comment by mrovi9...@gmail.com on 8 Feb 2015 at 11:06

GoogleCodeExporter commented 9 years ago 
Hi, are there any parts of code cleaned up? I could find a little time to do 
some cleaning, which can give some insight into tint2's design. Thanks

Original comment by ondrej.k...@gmail.com on 17 Feb 2015 at 8:21

GoogleCodeExporter commented 9 years ago 
Hello,

I think it would be best to defer this until after the next release, if it will 
happen at all. Generally, the code works well as it is now (except maybe a few 
of bugs, but it's not even clear if tint2 is the culprit). However the risk of 
introducing regressions is very high, especially since there is no way to test 
most of the functionality automatically.

We had an experience like this with a recent commit; we changed just a few 
lines in panel.c and we had some trouble afterwards.

The current plan for the next release (0.12) is to:
* fix some of the problems in 
https://code.google.com/p/tint2/issues/list?can=2&q=status%3DAccepted if 
possible, with a focus on defects; the ones marked 0.12 should make it to the 
next release, the others do not matter so much (but might still get upgraded in 
the meantime if it is proven otherwise);
* get tint2conf working, I started to work on it;
* update the docs where necessary;
* test, test, test. I would prefer to test most of the recent changes (maybe 
even all since 0.11) on multiple environments (Openbox, LXDE, Gnome 2, Gnome 3, 
Unity, XFCE, KDE, Fluxbox). We could come up with some scenarios: horizontal 
panel, vertical panel, thick, thin, auto-hidden, in the dock, not in the dock, 
single monitor, multi-monitor, which apps to show in the launcher etc. We could 
create a set of tint2rc's and expected results for these tests. The fact that 
testing takes so much time and we have not done it thoroughly for a while is 
the main reason I would like to avoid adding new features/enhancements at this 
point.

Original comment by mrovi9...@gmail.com on 17 Feb 2015 at 9:29

GoogleCodeExporter commented 9 years ago 
Project moved to GitLab.

You can find this issue at: https://gitlab.com/o9000/tint2/issues/468

Original comment by mrovi9...@gmail.com on 25 Apr 2015 at 11:15