search

Savjee / SavjeeCoin

A simple blockchain in Javascript. For educational purposes only.
MIT License
1.74k stars 752 forks source link

[45] isChainValid method must also check blocks chaining #48

Closed jhonderson closed 3 years ago

jhonderson commented 3 years ago

isChainValid method must also check that for each block in the chain its Block.previousHash actually match the Block.hash of its previous block.

https://github.com/Savjee/SavjeeCoin/issues/45

jhonderson commented 3 years ago

What about removing package-lock :9 and it will LGTM

@KaffinPX Done, thanks

KaffinPX commented 3 years ago

@Savjee Now its legit, can u pull it?

jhonderson commented 3 years ago

Looks good! Just 1 small remark and then it's ready to be merged. Could you also merge in the latest master branch? I added some CI based on GitHub Actions.

Updated latest changes from master branch :)

Savjee commented 3 years ago

Thanks again!

@KaffinPX I have no plans to do that, but I'm open to pull requests. Ideally the P2P aspect should be optional.