Question about the delays

SawFowl / GuiShopManager

GNU General Public License v3.0

1 stars 0 forks source link

Question about the delays #6

Closed Gershon123 closed 2 years ago

Gershon123 commented 2 years ago

I noticed the plugin uses 5 tick delays for switching between the menus. Is there a reason this is necessary?

SawFowl commented 2 years ago

Yes. There were some bugs caused by a player's ping. As a protection against them was made such a delay.

Gershon123 commented 2 years ago

Can you elaborate on which sort of bugs and how to reproduce them?

I cloned the project and wasn't able to notice any bugs when I removed the delays

SawFowl commented 2 years ago

As a rule, it was a visual dupe of items. The bug did not appear for everyone. I could not figure out the exact cause of the bug, but found that creating a small delay eliminates it. Of course you can change the code as you like. I suspect the bug was on one version of Sponge, but I didn't go through the versions.

Gershon123 commented 2 years ago

Sounds good thanks for the info