SawyerHood / animal-crossing-catch

Site to keep track of your critters in Animal Crossing
https://ac-catch.com
MIT License
58 stars 18 forks source link

HTML lang tag does not get changed when switching language #14

Closed julroy67 closed 4 years ago

julroy67 commented 4 years ago

Describe the bug When changing language the HTML lang tag does not get changed to the selected language. For CJK (Chinese, Japanese, Korean) languages, if the HTML lang tag is not set, Chinese variant of some of the characters may be shown instead of the local variant which will feel somewhat out of place for those users.

To Reproduce Steps to reproduce the behavior:

  1. Go to site
  2. Change language to Japanese
  3. Wrong variant of characters are shown (HTML lang tag is set to "en")

Expected behavior Change the HTML lang tag according to the language is set.

Screenshots Chinese variant: image

Japanese variant: image

Desktop (please complete the following information):

Smartphone (please complete the following information):

SawyerHood commented 4 years ago

Thanks for reporting! I just pushed a fix!