search

SawyerHood / animal-crossing-catch

Site to keep track of your critters in Animal Crossing
https://ac-catch.com
MIT License
58 stars 18 forks source link

Add basic support for music #22

Closed anaximander closed 4 years ago

anaximander commented 4 years ago

It's missing the code for generating the music data, which I can (and probably should) add, since the next "scraper.js" run won't have the music images in imgMap.js. That code just needs some cleanup since I had trouble scraping from the wiki directly and found an alternative source. Besides that, does this functionality look OK?

SawyerHood commented 4 years ago

It would be rad if you could add documentation on where you got the data from so that we can update in the future if needed

anaximander commented 4 years ago

I'll add the data source/script for sure, just need to clean up that code to get it ready for PR, and make the requested changes to the application code as well.

anaximander commented 4 years ago

Updated scraper (with notes and source csv). One caveat that I realized while updating the scraper is that the owners of the data source (see comments) ask politely to be credited somehow on the site. Up to you how to handle that part 🤷