search

SawyerHood / animal-crossing-catch

Site to keep track of your critters in Animal Crossing
https://ac-catch.com
MIT License
58 stars 18 forks source link

BUG FIX: fixing Birthday Song text to reflect actual gameplay #33

Closed ingernet closed 4 years ago

ingernet commented 4 years ago

I learned recently (on the Saturday before my birthday, actually) that in New Horizons, KK Slider refuses to perform the Birthday Song until your actual birthday. On the Saturday before, he says something about reserving that song for special occasions.

You can see this mentioned in Nookipedia, too: https://nookipedia.com/wiki/Secret_song#K.K._Birthday

ingernet commented 4 years ago

I ran the phrase through Google Translate for each of the languages, and then clicked the "reverse" button to make sure it translated back accurately. Happy to defer to fluent speakers of those other languages!

javmarina commented 4 years ago

Native Spanish speaker here. I would say "en tu cumpleaños" or "el día de tu cumpleaños", both of which are more informal. "En su cumpleaños" is correct nonetheless.

ingernet commented 4 years ago

Thank you, Javi! I almost went with “en tu cumpleaños” but then I remembered my high school Spanish teacher imploring us to use “su” and to err on the side of formality when in doubt. But! Now that you mention it, there is almost nothing about ACNH that is formal, unless you count Blathers. I will put in a PR later today, making this language fix, unless you beat me to it. :)

On Fri, Jun 26, 2020 at 2:45 PM Javi Marina notifications@github.com wrote:

Native Spanish speaker here. I would say "en tu cumpleaños" or "el día de tu cumpleaños", both of which are more informal. "En su cumpleaños" is correct nonetheless.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SawyerHood/animal-crossing-catch/pull/33#issuecomment-650417356, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABOLG6W7BFZO3AND4FQGNYLRYUJIBANCNFSM4OJTIZWA .

javmarina commented 4 years ago

I will let you fix it! 😁 We could also wait for other contributors' opinions (@julroy67 is the one that comes to my mind right now).

julroy67 commented 4 years ago

@javmarina Thanks for the notification. I've made a new PR (#34) to fix the translations! :smile:

javmarina commented 4 years ago

I also made a new PR (https://github.com/SawyerHood/animal-crossing-catch/pull/35) in order to fix the Spanish string @ingernet .