search

SaxxonPike / NextLevelSeven

A fast and simple library for Health Level Seven (HL7) v2 messages.
ISC License
22 stars 21 forks source link

Add NetStandard 2.0 #4

Closed kfrancis closed 6 years ago

kfrancis commented 6 years ago

Hey,

Question - I'd like to add NetStandard support for your library. I've already done all the work to add multi-targeting to your library. Would you be ok with that pull request? The actual change is simple, I did have to reconfigure the test project but all tests are passing in both full .NET Framework and .NET Core now.

SaxxonPike commented 6 years ago

This sounds great! Put in the request and I'll look it over. Thanks for your efforts :)

SaxxonPike commented 6 years ago

The latest commit should add this to the list of targeted frameworks. There will need to be further work to bring the test project's NUnit up to 3 so that we can also run the tests on .NET Standard 2.0. However, as-is, the library compiles for both .NET 4.5 and .NET Standard 2.0.

kfrancis commented 6 years ago

I can do that, sorry for the delay.

kfrancis commented 6 years ago

If you do end up accepting that pull request, would you mind pushing it out to nuget pretty please?

SaxxonPike commented 6 years ago

Going to put this out as 1.0.1. For long story reasons.

SaxxonPike commented 6 years ago

@kfrancis It looks like this was approved and indexed, and there are some downloads already. So, I'm going to assume all is well. If any further issues crop up, let's reopen new issues more appropriate to whatever's up. Thanks for everything!

It has been published at: https://www.nuget.org/packages/NextLevelSeven/