Say-Their-Name / say-their-names-web

Open-source platform that raises awareness of the injustice and often forgotten names of racial inequality.
https://saytheirnames.io/
MIT License
56 stars 28 forks source link

Feat:add search Bar functionality #118

Open mbayefaye opened 4 years ago

mbayefaye commented 4 years ago

What does this PR do?

-Add search bar . i tried to put the search Bar in the navbar but it would messed up the navigation,if anyone know how to do it feel free to do so.

Description of Task to be completed?

-search victims by their name . ⚠️ Numeric is not allowed.

How should this be manually tested?

-search a victim.

What are the relevant Trello Card stories? Trello Card Item

-

Pull Request Type (check one)

Developer Checklist

Screenshots (if appropriate)

Easybuoy commented 4 years ago

We'd revisit this in v2

mbayefaye commented 4 years ago

@Easybuoy so we dont need a search bar in v1?.

Easybuoy commented 4 years ago

@Easybuoy so we dont need a search bar in v1?.

Yes, it was removed from v1

kndri commented 4 years ago

I got the search to be in the nav and got it to autocomplete as you type within it.

Haven't gotten to the test. Maybe someone would like to pick it up from here?

ashleygraf101 commented 4 years ago

It works great on desktop.

On mobile I noticed you have to add in a space at the end. Clicking return without it, the search result doesn't load.

As a style thing, I think it would be great if the search bar was encapsulated by the navbar like on desktop, but I'll defer to the UX team on that. Nav bar

The error checking appears to be too restrictive. People with nicknames can't be searched. Dominique Falls