Open mbayefaye opened 4 years ago
We'd revisit this in v2
@Easybuoy so we dont need a search bar in v1?.
@Easybuoy so we dont need a search bar in v1?.
Yes, it was removed from v1
I got the search to be in the nav and got it to autocomplete as you type within it.
Haven't gotten to the test. Maybe someone would like to pick it up from here?
It works great on desktop.
On mobile I noticed you have to add in a space at the end. Clicking return without it, the search result doesn't load.
As a style thing, I think it would be great if the search bar was encapsulated by the navbar like on desktop, but I'll defer to the UX team on that.
The error checking appears to be too restrictive. People with nicknames can't be searched.
What does this PR do?
-Add search bar . i tried to put the search Bar in the navbar but it would messed up the navigation,if anyone know how to do it feel free to do so.
Description of Task to be completed?
-search victims by their name . ⚠️ Numeric is not allowed.
How should this be manually tested?
-search a victim.
What are the relevant Trello Card stories? Trello Card Item
-
Pull Request Type (check one)
Developer Checklist
Screenshots (if appropriate)